Bug 33173 - Save and continue button in standard cataloging module broken
Summary: Save and continue button in standard cataloging module broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-08 18:49 UTC by Nick Clemens (kidclamp)
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19
Circulation function:

Attachments
Bug 33173: Save and continue button in standard cataloging module broken (1.30 KB, patch)
2023-03-08 18:51 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 33173: Save and continue button in standard cataloging module broken (1.37 KB, patch)
2023-03-08 19:16 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 33173: Save and continue button in standard cataloging module broken (1.42 KB, patch)
2023-03-09 21:27 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-03-08 18:49:50 UTC 
To recreate:
1 - Edit a record in the standard editor
2 - Click on to tab 2
3 - Click 'Save and continue'
4 - Error: tab is not defined
Comment 1 Nick Clemens (kidclamp) 2023-03-08 18:51:56 UTC 
Created attachment 147974 [details] [review]
Bug 33173: Save and continue button in standard cataloging module broken

To test:
1 - Edit a record in the standard editor
2 - Click on to tab 2
3 - Click 'Save and continue'
4 - Error: tab is not defined
5 - Apply patch
6 - Reload page and try again
7 - Fixed!
Comment 2 ByWater Sandboxes 2023-03-08 19:16:45 UTC 
Created attachment 147978 [details] [review]
Bug 33173: Save and continue button in standard cataloging module broken

To test:
1 - Edit a record in the standard editor
2 - Click on to tab 2
3 - Click 'Save and continue'
4 - Error: tab is not defined
5 - Apply patch
6 - Reload page and try again
7 - Fixed!

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-03-09 21:27:50 UTC 
Created attachment 148035 [details] [review]
Bug 33173: Save and continue button in standard cataloging module broken

To test:
1 - Edit a record in the standard editor
2 - Click on to tab 2
3 - Click 'Save and continue'
4 - Error: tab is not defined
5 - Apply patch
6 - Reload page and try again
7 - Fixed!

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-03-10 13:24:17 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-03-10 16:26:37 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass (lukeg) 2023-03-14 20:26:03 UTC 
Backported to 22.05.x for upcoming 22.05.11
Comment 7 Arthur Suzuki 2023-03-30 07:49:03 UTC 
applied to 21.11 for 21.11.19
Comment 8 Wainui Witika-Park 2023-04-27 05:54:33 UTC 
Not backported to 21.05.x