The word "offset" is now a keyword. At the very least we need to escape the fieldname with backticks. It would be nice to switch to Koha::Objects for this module eventually. C4::Matcher::_store_matchpoint(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'offset, length) VALUES ('27', '1', '999'...' at line 2 at /usr/share/koha/lib/C4/Matcher.pm line 314
Created attachment 148017 [details] [review] Bug 33183: Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6 The word "offset" is now a keyword. At the very least we need to escape the fieldname with backticks. It would be nice to switch to Koha::Objects for this module eventually. C4::Matcher::_store_matchpoint(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'offset, length) VALUES ('27', '1', '999'...' at line 2 at /usr/share/koha/lib/C4/Matcher.pm line 314 Test Plan: 1) Set up Koha with MariaDB 10.6 2) Attempt to create a matching rule 3) Note the error screen 4) Apply this patch 5) Restart all the things! 6) Attempt to create another matching rule 7) No errors this time
Created attachment 148025 [details] [review] Bug 33183: Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6 The word "offset" is now a keyword. At the very least we need to escape the fieldname with backticks. It would be nice to switch to Koha::Objects for this module eventually. C4::Matcher::_store_matchpoint(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'offset, length) VALUES ('27', '1', '999'...' at line 2 at /usr/share/koha/lib/C4/Matcher.pm line 314 Test Plan: 1) Set up Koha with MariaDB 10.6 2) Attempt to create a matching rule 3) Note the error screen 4) Apply this patch 5) Restart all the things! 6) Attempt to create another matching rule 7) No errors this time Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I couldn't test with this specific DBMS version, but I did a regression test and the code looks good.
Tested with: mariadb Ver 15.1 Distrib 10.5.18-MariaDB, for debian-linux-gnu (x86_64) using EditLine wrapper I also verified we have backticks in kohastructure.sql.
Created attachment 148222 [details] [review] Bug 33183: Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6 The word "offset" is now a keyword. At the very least we need to escape the fieldname with backticks. It would be nice to switch to Koha::Objects for this module eventually. C4::Matcher::_store_matchpoint(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'offset, length) VALUES ('27', '1', '999'...' at line 2 at /usr/share/koha/lib/C4/Matcher.pm line 314 Test Plan: 1) Set up Koha with MariaDB 10.6 2) Attempt to create a matching rule 3) Note the error screen 4) Apply this patch 5) Restart all the things! 6) Attempt to create another matching rule 7) No errors this time Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.12
applied to 21.11.x for 21.11.20
Not backported to 21.05.x