Continuing the work of Bug 32571, the article requests management and holds awaiting pickup templates should be updated to use the new WRAPPER for tabs.
Created attachment 148028 [details] [review] Bug 33187: Use template wrapper for tabs article requests and holds awaiting pickup pages This patch updates the article requests management and holds awaiting pickup templates in the staff interface so that they use the new WRAPPER directive for building tabs. To test, apply the patch and make sure the ArticleRequests system preference is enabled. - Go to Circulation -> Article requests - You should see three tabs, "New," "Pending," and "Processing." - The tabs should look correct and work correctly. - Go to Circulation -> Holds awaiting pickup - You should see three tabs, "Holds waiting", "Holds waiting over X days," and "Holds with cancellation requests." ("X" is the value in the ReservesMaxPickUpDelay system preference)
Created attachment 148125 [details] [review] Bug 33187: Use template wrapper for tabs article requests and holds awaiting pickup pages This patch updates the article requests management and holds awaiting pickup templates in the staff interface so that they use the new WRAPPER directive for building tabs. To test, apply the patch and make sure the ArticleRequests system preference is enabled. - Go to Circulation -> Article requests - You should see three tabs, "New," "Pending," and "Processing." - The tabs should look correct and work correctly. - Go to Circulation -> Holds awaiting pickup - You should see three tabs, "Holds waiting", "Holds waiting over X days," and "Holds with cancellation requests." ("X" is the value in the ReservesMaxPickUpDelay system preference) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 149321 [details] [review] Bug 33187: Use template wrapper for tabs article requests and holds awaiting pickup pages This patch updates the article requests management and holds awaiting pickup templates in the staff interface so that they use the new WRAPPER directive for building tabs. To test, apply the patch and make sure the ArticleRequests system preference is enabled. - Go to Circulation -> Article requests - You should see three tabs, "New," "Pending," and "Processing." - The tabs should look correct and work correctly. - Go to Circulation -> Holds awaiting pickup - You should see three tabs, "Holds waiting", "Holds waiting over X days," and "Holds with cancellation requests." ("X" is the value in the ReservesMaxPickUpDelay system preference) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x