One systems with many branches, or complex rules calculating the pickup locations can be expensive. It appears we are calling $biblio->pickup_locations that is only used during multi-holds for all of our holds
Created attachment 148096 [details] [review] Bug 33198: Don't calculate pickup locations per bib unless placing multiple holds For single bibs we use an ajax select2 dropdown, and we don't use this value To test: 1 - Place some holds on single bibs 2 - Confirm dropdowns for pickup location work as expected 3 - Do the same for multiple bibs selected from search results 4 - Apply patch 5 - Confirm there is no change after the patch
Created attachment 148126 [details] [review] Bug 33198: Don't calculate pickup locations per bib unless placing multiple holds For single bibs we use an ajax select2 dropdown, and we don't use this value To test: 1 - Place some holds on single bibs 2 - Confirm dropdowns for pickup location work as expected 3 - Do the same for multiple bibs selected from search results 4 - Apply patch 5 - Confirm there is no change after the patch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 148532 [details] [review] Bug 33198: Don't calculate pickup locations per bib unless placing multiple holds For single bibs we use an ajax select2 dropdown, and we don't use this value To test: 1 - Place some holds on single bibs 2 - Confirm dropdowns for pickup location work as expected 3 - Do the same for multiple bibs selected from search results 4 - Apply patch 5 - Confirm there is no change after the patch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Can this be considered for backport?
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.12
applied to 21.11.x for 21.11.20