Bug 33203 - Overdue notice/status triggers letter selection is ambiguous
Summary: Overdue notice/status triggers letter selection is ambiguous
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Aleisha Amohia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-10 21:55 UTC by Lucas Gass (lukeg)
Modified: 2024-07-04 20:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00
Circulation function:


Attachments
Bug 33203: Add letter_code to the letter dropdown text (2.24 KB, patch)
2023-03-10 21:59 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 33203: Add letter_code to the letter dropdown text (2.31 KB, patch)
2023-03-14 09:57 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33203: Add letter_code to the letter dropdown text (2.41 KB, patch)
2023-04-28 03:59 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-03-10 21:55:55 UTC
When editing notice/status triggers the letter selection is too vague. For example:

1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'.
2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'.


It would help with general troubleshooting if could also see the letter_code in the dropdown.
Comment 1 Lucas Gass (lukeg) 2023-03-10 21:59:08 UTC
Created attachment 148100 [details] [review]
Bug 33203: Add letter_code to the letter dropdown text

To test:
1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'.
2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'.
3. Apply patch and try again.
4. The new notice should now read "Overdue notice (ABC)" and should be easy to distinguish from the original.
Comment 2 ByWater Sandboxes 2023-03-14 09:57:43 UTC
Created attachment 148154 [details] [review]
Bug 33203: Add letter_code to the letter dropdown text

To test:
1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'.
2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'.
3. Apply patch and try again.
4. The new notice should now read "Overdue notice (ABC)" and should be easy to distinguish from the original.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2023-03-14 09:59:22 UTC
Works as described, thanks for the patch.
Comment 4 Aleisha Amohia 2023-04-28 03:59:20 UTC
Created attachment 150352 [details] [review]
Bug 33203: Add letter_code to the letter dropdown text

To test:
1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'.
2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'.
3. Apply patch and try again.
4. The new notice should now read "Overdue notice (ABC)" and should be easy to distinguish from the original.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-05-18 14:38:16 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-06-08 16:52:55 UTC
Enhancement - not backporting to 22.11.x