Recalls to pull report does not show accurate information. Recalled items that are in transit should not show on the recalls to pull page, as the item has been allocated already, and it's not on the shelf ready to pull. To reproduce: 1. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B 3. Place a recall on Item A for Patron B. Change the pickup library so it isn't your default library 4. Log back into the staff interface 5. Check in Item A, make sure you're not logged into the selected pickup library so we trigger a transfer. 6. Confirm the recall and transfer. 7. Go to Circulation -> Recalls to pull. Notice the recall shows here, even though it is not ready to pull. Also, for records that have multiple recalls, the information may show wrongly on recalls to pull. To reproduce: 1. Cancel any recalls on Item A/Biblio A. 2. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B. 3. Place a recall on Item A for Patron B. 4. Log into the OPAC as Patron C. 5. Place a recall on Item A for Patron C. Item A should now be checked out to Patron A, with two recalls on it for Patrons B and C. 6. Log back into the staff interface. 7. Check in Item A. Confirm the recall as waiting for Patron B. 8. Go to Circulation -> Recalls to pull. Notice the recall for Patron C shows here, even though the one item that could fill this recall has already been allocated to Patron B.
Created attachment 148151 [details] [review] Bug 33220: Fix recalls to pull to not show in transit or allocated items This patch fixes the Recalls to pull circulation report so that it does not show items that are already allocated to another recall. This requires the UseRecalls system preference to be enabled and recalls circulation and fines rules to be configured. To test: 1. Cancel any recalls on Item A/Biblio A. 2. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B. 3. Place a recall on Item A for Patron B. Change the pickup library so it isn't your default library. 4. Log into the OPAC as Patron C. 5. Place a recall on Item A for Patron C. Item A should now be checked out to Patron A, with two recalls on it for Patrons B and C. 6. Log back into the staff interface. 7. Check in Item A. Confirm the recall and transfer for Patron B. 8. Go to Circulation -> Recalls to pull. Notice the recall for Patron C shows here, even though the one item that could fill this recall has already been allocated to Patron B and is in transit 9. Apply the patch and restart services 10. Refresh the Recalls to pull page 11. Confirm the recall no longer shows on the Recalls to pull page --> SUCCESS 12. Go to Biblio A and add a second item - Item B 13. Go back to Recalls to pull and refresh the page 14. Confirm the recall for Patron C now shows and can be filled by Item B Sponsored-by: Auckland University of Technology
Created attachment 149121 [details] [review] Bug 33220: Fix recalls to pull to not show in transit or allocated items This patch fixes the Recalls to pull circulation report so that it does not show items that are already allocated to another recall. This requires the UseRecalls system preference to be enabled and recalls circulation and fines rules to be configured. To test: 1. Cancel any recalls on Item A/Biblio A. 2. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B. 3. Place a recall on Item A for Patron B. Change the pickup library so it isn't your default library. 4. Log into the OPAC as Patron C. 5. Place a recall on Item A for Patron C. Item A should now be checked out to Patron A, with two recalls on it for Patrons B and C. 6. Log back into the staff interface. 7. Check in Item A. Confirm the recall and transfer for Patron B. 8. Go to Circulation -> Recalls to pull. Notice the recall for Patron C shows here, even though the one item that could fill this recall has already been allocated to Patron B and is in transit 9. Apply the patch and restart services 10. Refresh the Recalls to pull page 11. Confirm the recall no longer shows on the Recalls to pull page --> SUCCESS 12. Go to Biblio A and add a second item - Item B 13. Go back to Recalls to pull and refresh the page 14. Confirm the recall for Patron C now shows and can be filled by Item B Sponsored-by: Auckland University of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Great patch and test script...all works perfectly as described.
Changes make sense, works as described, QA scripts are happy.
Created attachment 150389 [details] [review] Bug 33220: Fix recalls to pull to not show in transit or allocated items This patch fixes the Recalls to pull circulation report so that it does not show items that are already allocated to another recall. This requires the UseRecalls system preference to be enabled and recalls circulation and fines rules to be configured. To test: 1. Cancel any recalls on Item A/Biblio A. 2. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B. 3. Place a recall on Item A for Patron B. Change the pickup library so it isn't your default library. 4. Log into the OPAC as Patron C. 5. Place a recall on Item A for Patron C. Item A should now be checked out to Patron A, with two recalls on it for Patrons B and C. 6. Log back into the staff interface. 7. Check in Item A. Confirm the recall and transfer for Patron B. 8. Go to Circulation -> Recalls to pull. Notice the recall for Patron C shows here, even though the one item that could fill this recall has already been allocated to Patron B and is in transit 9. Apply the patch and restart services 10. Refresh the Recalls to pull page 11. Confirm the recall no longer shows on the Recalls to pull page --> SUCCESS 12. Go to Biblio A and add a second item - Item B 13. Go back to Recalls to pull and refresh the page 14. Confirm the recall for Patron C now shows and can be filled by Item B Sponsored-by: Auckland University of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for next release