Bug 33246 - itemBarcodeFallbackSearch search results should show whether or not items are available
Summary: itemBarcodeFallbackSearch search results should show whether or not items are...
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 33248
  Show dependency treegraph
 
Reported: 2023-03-16 15:10 UTC by Andrew Fuerste-Henry
Modified: 2023-06-08 16:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This adds a label 'Checked out' to the result list of items when using `itemBarcodeFallbackSearch`.
Version(s) released in:
23.05.00


Attachments
Bug 33246: Show the onloan status on the BarcodeFallbackSearch result (1.41 KB, patch)
2023-05-11 12:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33246: Show the onloan status on the BarcodeFallbackSearch result (1.47 KB, patch)
2023-05-14 11:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33246: Add some space between icon and text when there is only one result (1.82 KB, patch)
2023-05-14 11:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33246: Show the onloan status on the BarcodeFallbackSearch result (1.56 KB, patch)
2023-05-17 14:27 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33246: Add some space between icon and text when there is only one result (1.92 KB, patch)
2023-05-17 14:27 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2023-03-16 15:10:17 UTC
When itemBarcodeFallbackSearch is enabled, the table of search results it shows doesn't include anything to indicate whether or not an item is available. We should at least show the value from items.onloan to let users know if the item they're selecting is currently checked out to another patron.
Comment 1 Jonathan Druart 2023-05-11 12:03:42 UTC
Created attachment 151071 [details] [review]
Bug 33246: Show the onloan status on the BarcodeFallbackSearch result
Comment 2 Jonathan Druart 2023-05-11 12:04:10 UTC
Something like that? In a different column?
Comment 3 Katrin Fischer 2023-05-14 11:40:22 UTC
Created attachment 151172 [details] [review]
Bug 33246: Show the onloan status on the BarcodeFallbackSearch result

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-05-14 11:40:25 UTC
Created attachment 151173 [details] [review]
Bug 33246: Add some space between icon and text when there is only one result

When there is only one result line, the text "Checked out" would
show directly after the icon at the end of the title. This makes sure
there will always be a little space between them.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-05-14 11:42:42 UTC
I like that it's at the beginning of the table, so quite obvious. It's also only a small change, so we could consider putting it in 22.11 as well.

I imagine maybe having a filter on 'checked out' would be nice that is set by default and can be unset if needed. Usually the item presented to you should not be the checked out in this situation.

It could also be nice to have a different background color for the full line as they can be a little long.
Comment 6 Marcel de Rooy 2023-05-17 14:27:35 UTC
Created attachment 151343 [details] [review]
Bug 33246: Show the onloan status on the BarcodeFallbackSearch result

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Marcel de Rooy 2023-05-17 14:27:38 UTC
Created attachment 151344 [details] [review]
Bug 33246: Add some space between icon and text when there is only one result

When there is only one result line, the text "Checked out" would
show directly after the icon at the end of the title. This makes sure
there will always be a little space between them.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2023-05-17 14:28:08 UTC
+                                                                [% IF item.onloan %]<span style="float: right; color: red; margin-left:5px;">Checked out</span>[% END %]

So glad we have css files, LOL
Comment 9 Tomás Cohen Arazi 2023-05-18 14:36:03 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Matt Blenkinsop 2023-06-08 16:47:28 UTC
Enhancement - not backporting to 22.11.x