Bug 33265 - Additional unformatted navigation items when on serial receive page
Summary: Additional unformatted navigation items when on serial receive page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Lucas Gass (lukeg)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-17 13:49 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33265: Clean up serial links on serial edit page (3.91 KB, patch)
2023-03-17 20:56 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 33265: Clean up serial links on serial edit page (3.97 KB, patch)
2023-04-04 13:50 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 33265: Clean up serial links on serial edit page (4.02 KB, patch)
2023-04-09 11:56 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-03-17 13:49:03 UTC 
When receiving issues for a serial subscription (/cgi-bin/koha/serials/serials-edit.pl), there are 3 navigation items below the normal navigation that appear as links with list points in front:


* Serial collection #1
* Subscription #1
* Show biblio

These look somewhat old. Bilbio should also be changed to bibliographic record.
Comment 1 Lucas Gass (lukeg) 2023-03-17 20:56:52 UTC Comment hidden (obsolete)
Comment 2 ByWater Sandboxes 2023-04-04 13:50:59 UTC 
Created attachment 149128 [details] [review]
Bug 33265: Clean up serial links on serial edit page

To test:
1. Reviece a serial
2. Notice the unstyled links:
    * Serial collection #1
    * Subscription #1
    * Show biblio
3. Apply pacth
4. The links should now be styled.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-04-04 13:51:25 UTC 
Works beautifully. Thanks.
Comment 4 Katrin Fischer 2023-04-09 11:56:15 UTC 
Created attachment 149357 [details] [review]
Bug 33265: Clean up serial links on serial edit page

To test:
1. Reviece a serial
2. Notice the unstyled links:
    * Serial collection #1
    * Subscription #1
    * Show biblio
3. Apply pacth
4. The links should now be styled.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-04-09 11:57:14 UTC 
There is a little more margin at the top of these elements to the other navigation items, but I think that works here.
Comment 6 Tomás Cohen Arazi (tcohen) 2023-04-12 14:44:31 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-04-17 09:11:19 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass (lukeg) 2023-05-05 22:01:25 UTC 
Doesn't apply cleanly to 22.05.x, no backport.