Bug 33266 - Patron name missing space before surname
Summary: Patron name missing space before surname
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
: 33369 (view as bug list)
Depends on: 31028
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-17 14:27 UTC by Andrew Fuerste-Henry
Modified: 2023-12-28 20:42 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
missing space (116.33 KB, image/png)
2023-03-17 14:27 UTC, Andrew Fuerste-Henry
Details
Bug 33266: Fix missing space in patron title (1.83 KB, patch)
2023-03-17 17:52 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33266: Fix missing space in patron title (1.86 KB, patch)
2023-03-17 17:59 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2023-03-17 14:27:05 UTC
Created attachment 148351 [details]
missing space

Display of patron names on /cgi-bin/koha/circ/circulation.pl and /cgi-bin/koha/members/moremember.pl are missing a space before the patron's last name. Henry Acevedo appears as HenryAcevedo. If you give him a middle name he's Henry JamesAcevedo. Adding a nickname makes a space appear properly.
Comment 1 Matt Blenkinsop 2023-03-17 17:52:51 UTC
Created attachment 148381 [details] [review]
Bug 33266: Fix missing space in patron title

This patch fixes the missing space in patron-title.inc

Test plan:
1) Visit a patron's detail page and observe that there should be a
   missing space between the first name and the surname
2) Apply patch
3) The name should now be correctly formatted
Comment 2 Lucas Gass 2023-03-17 17:59:52 UTC
Created attachment 148382 [details] [review]
Bug 33266: Fix missing space in patron title

This patch fixes the missing space in patron-title.inc

Test plan:
1) Visit a patron's detail page and observe that there should be a
   missing space between the first name and the surname
2) Apply patch
3) The name should now be correctly formatted

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Lucas Gass 2023-03-17 18:00:34 UTC
Thanks Matt, trivial fix can go straight to PQA.
Comment 4 Tomás Cohen Arazi 2023-03-20 12:43:24 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-03-21 16:45:14 UTC
Not backporting, dependent on bug 31028 so produces a conflict
Comment 6 Matt Blenkinsop 2023-03-30 14:21:33 UTC
*** Bug 33369 has been marked as a duplicate of this bug. ***
Comment 7 Martin Renvoize 2023-04-11 08:46:10 UTC
Interesting.. I thought I'd already fixed this with `Bug 31028: (follow-up) Fix missing whitespace on patron-title`.. did I miss a bit?