The JS which triggers the display of a default tab on the advanced search page uses a selector which isn't specific enough now that the header search tabs are Bootstrap too.
There are other pages which need the same correction, so I'm re-titling the bug.
Created attachment 148420 [details] [review] Bug 33278: Correct JS for activating default tab on various pages The conversion of the header search tabs to Bootstrap resulted in a bug on several staff interface pages: The first tab isn't selected by default. The jQuery selector isn't specific enough. The patch also corrects a template error which was introduced to merge-record.inc by Bug 32683. To test, apply the patch and test the following pages to confirm that the first tab on each page is selected by default: - Catalog -> Advanced search - Catalog -> MARC details - Catalog -> Search results -> Merge - Administration -> Authorized values -> Edit - Administratoin -> Library transfer limits - Administration -> Item types -> Edit - Authorities -> Authority details - Authorities -> Search -> Merge
Created attachment 148468 [details] [review] Bug 33278: Correct JS for activating default tab on various pages The conversion of the header search tabs to Bootstrap resulted in a bug on several staff interface pages: The first tab isn't selected by default. The jQuery selector isn't specific enough. The patch also corrects a template error which was introduced to merge-record.inc by Bug 32683. To test, apply the patch and test the following pages to confirm that the first tab on each page is selected by default: - Catalog -> Advanced search - Catalog -> MARC details - Catalog -> Search results -> Merge - Administration -> Authorized values -> Edit - Administratoin -> Library transfer limits - Administration -> Item types -> Edit - Authorities -> Authority details - Authorities -> Search -> Merge Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described, thanks for the patch.
Created attachment 148549 [details] [review] Bug 33278: Correct JS for activating default tab on various pages The conversion of the header search tabs to Bootstrap resulted in a bug on several staff interface pages: The first tab isn't selected by default. The jQuery selector isn't specific enough. The patch also corrects a template error which was introduced to merge-record.inc by Bug 32683. To test, apply the patch and test the following pages to confirm that the first tab on each page is selected by default: - Catalog -> Advanced search - Catalog -> MARC details - Catalog -> Search results -> Merge - Administration -> Authorized values -> Edit - Administratoin -> Library transfer limits - Administration -> Item types -> Edit - Authorities -> Authority details - Authorities -> Search -> Merge Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport.