Silly error from commit 821808ec31176d662e518418c9ff8a71948e1a4b Bug 32939: Use APIClient to replace PATCH requests + const body = params.body + ? typeof str === "string" + ? params.body + : JSON.stringify(params.body) + : undefined; typeof str === "string" must be typeof params.body === "string"
Created attachment 148441 [details] [review] Bug 33290: Fix incorrect variable in http-client.js Silly error from commit 821808ec31176d662e518418c9ff8a71948e1a4b Bug 32939: Use APIClient to replace PATCH requests + const body = params.body + ? typeof str === "string" + ? params.body + : JSON.stringify(params.body) + : undefined; typeof str === "string" must be typeof params.body === "string" Test plan: With this patch, bug 33289 is not working properly. The body contains "pref_var=value" instead of pref_var=value and the syspref `var` contains `value"` Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 148595 [details] [review] Bug 33290: Fix incorrect variable in http-client.js Silly error from commit 821808ec31176d662e518418c9ff8a71948e1a4b Bug 32939: Use APIClient to replace PATCH requests + const body = params.body + ? typeof str === "string" + ? params.body + : JSON.stringify(params.body) + : undefined; typeof str === "string" must be typeof params.body === "string" Test plan: With this patch, bug 33289 is not working properly. The body contains "pref_var=value" instead of pref_var=value and the syspref `var` contains `value"` Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 148630 [details] [review] Bug 33290: Fix incorrect variable in http-client.js Silly error from commit 821808ec31176d662e518418c9ff8a71948e1a4b Bug 32939: Use APIClient to replace PATCH requests + const body = params.body + ? typeof str === "string" + ? params.body + : JSON.stringify(params.body) + : undefined; typeof str === "string" must be typeof params.body === "string" Test plan: With this patch, bug 33289 is not working properly. The body contains "pref_var=value" instead of pref_var=value and the syspref `var` contains `value"` Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
(In reply to Matt Blenkinsop from comment #5) > Nice work everyone! > > Pushed to stable for 22.11.x Hi Matt, should it be 22.11.05 in the "Version(s) released in"?
Not needed in 22.05.x, no backport