Bug 33307 - Use template wrapper for tabs: Lists
Summary: Use template wrapper for tabs: Lists
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-22 15:36 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33307: Use template wrapper for tabs: Lists (4.21 KB, patch)
2023-03-22 15:48 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33307: Use template wrapper for tabs: Lists (4.27 KB, patch)
2023-03-23 09:46 UTC, PTFS Europe Sandboxes 		Details | Diff | Splinter Review
5# Attachment to Bug 33307 - Use template wrapper for tabs: Lists (4.33 KB, patch)
2023-04-08 21:35 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-22 15:36:08 UTC 
Continuing the work of Bug 32571, I would like to update the lists page in the staff client to use the new WRAPPER for tabs
Comment 1 Owen Leonard 2023-03-22 15:48:12 UTC 
Created attachment 148563 [details] [review]
Bug 33307: Use template wrapper for tabs: Lists

This patch updates the lists template so that it uses the new WRAPPER
directive to build tabbed navigation.

To test, apply the patch and go to the lists page in the staff
interface.

- Confirm that the two tabs, "Your lists" and "Public lists" look
  correct and work correctly.
- Test that the correct tab is selected when you add the "public" or
  "private" parameter to the url:

  /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1
  /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0
Comment 2 PTFS Europe Sandboxes 2023-03-23 09:46:49 UTC 
Created attachment 148594 [details] [review]
Bug 33307: Use template wrapper for tabs: Lists

This patch updates the lists template so that it uses the new WRAPPER
directive to build tabbed navigation.

To test, apply the patch and go to the lists page in the staff
interface.

- Confirm that the two tabs, "Your lists" and "Public lists" look
  correct and work correctly.
- Test that the correct tab is selected when you add the "public" or
  "private" parameter to the url:

  /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1
  /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2023-03-23 09:52:01 UTC 
Works as described, thanks for the patch.
Comment 4 Katrin Fischer 2023-04-08 21:35:33 UTC 
Created attachment 149318 [details] [review]
5# Attachment to Bug 33307 - Use template wrapper for tabs: Lists

Bug 33307: Use template wrapper for tabs: Lists

This patch updates the lists template so that it uses the new WRAPPER
directive to build tabbed navigation.

To test, apply the patch and go to the lists page in the staff
interface.

- Confirm that the two tabs, "Your lists" and "Public lists" look
  correct and work correctly.
- Test that the correct tab is selected when you add the "public" or
  "private" parameter to the url:

  /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1
  /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-04-13 14:49:44 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:38:03 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.