Continuing the work of Bug 32571, I would like to update the suggestions page in the staff client to use the new WRAPPER for tabs
Created attachment 148604 [details] [review] Bug 33310: Use template wrapper for tabs: Suggestions This patch updates the suggestions template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the suggestions page in the staff interface. - By default you suggestions should be organized by status, with a separate tab for each status (pending, accepted, etc). - Use the "Organize by" form in the sidebar to change how suggestions are listed. In each case confirm that the tabs are redisplayed correctly.
Created attachment 148783 [details] [review] Bug 33310: Use template wrapper for tabs: Suggestions This patch updates the suggestions template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the suggestions page in the staff interface. - By default you suggestions should be organized by status, with a separate tab for each status (pending, accepted, etc). - Use the "Organize by" form in the sidebar to change how suggestions are listed. In each case confirm that the tabs are redisplayed correctly. Works as advertised. 3/3 Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Patch doesn't apply, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33310: Use template wrapper for tabs: Suggestions Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 33310: Use template wrapper for tabs: Suggestions
Created attachment 149614 [details] [review] Bug 33310: Use template wrapper for tabs: Suggestions This patch updates the suggestions template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the suggestions page in the staff interface. - By default you suggestions should be organized by status, with a separate tab for each status (pending, accepted, etc). - Use the "Organize by" form in the sidebar to change how suggestions are listed. In each case confirm that the tabs are redisplayed correctly. Works as advertised. 3/3 Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Created attachment 149618 [details] [review] Bug 33310: Use template wrapper for tabs: Suggestions This patch updates the suggestions template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the suggestions page in the staff interface. - By default you suggestions should be organized by status, with a separate tab for each status (pending, accepted, etc). - Use the "Organize by" form in the sidebar to change how suggestions are listed. In each case confirm that the tabs are redisplayed correctly. Works as advertised. 3/3 Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Created attachment 149993 [details] [review] Bug 33310: Use template wrapper for tabs: Suggestions This patch updates the suggestions template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the suggestions page in the staff interface. - By default you suggestions should be organized by status, with a separate tab for each status (pending, accepted, etc). - Use the "Organize by" form in the sidebar to change how suggestions are listed. In each case confirm that the tabs are redisplayed correctly. Works as advertised. 3/3 Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.