Bug 33310 - Use template wrapper for tabs: Suggestions
Summary: Use template wrapper for tabs: Suggestions
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-22 16:23 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33310: Use template wrapper for tabs: Suggestions (48.46 KB, patch)
2023-03-23 11:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33310: Use template wrapper for tabs: Suggestions (48.54 KB, patch)
2023-03-27 14:42 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 33310: Use template wrapper for tabs: Suggestions (48.65 KB, patch)
2023-04-13 16:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33310: Use template wrapper for tabs: Suggestions (48.65 KB, patch)
2023-04-13 17:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33310: Use template wrapper for tabs: Suggestions (48.71 KB, patch)
2023-04-20 20:47 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-22 16:23:26 UTC
Continuing the work of Bug 32571, I would like to update the suggestions page in the staff client to use the new WRAPPER for tabs
Comment 1 Owen Leonard 2023-03-23 11:04:34 UTC
Created attachment 148604 [details] [review]
Bug 33310: Use template wrapper for tabs: Suggestions

This patch updates the suggestions template so that it uses the new
WRAPPER directive to build tabbed navigation.

To test, apply the patch and go to the suggestions page in the staff
interface.

- By default you suggestions should be organized by status, with a
  separate tab for each status (pending, accepted, etc).
- Use the "Organize by" form in the sidebar to change how suggestions
  are listed. In each case confirm that the tabs are redisplayed
  correctly.
Comment 2 Paul Derscheid 2023-03-27 14:42:16 UTC
Created attachment 148783 [details] [review]
Bug 33310: Use template wrapper for tabs: Suggestions

This patch updates the suggestions template so that it uses the new
WRAPPER directive to build tabbed navigation.

To test, apply the patch and go to the suggestions page in the staff
interface.

- By default you suggestions should be organized by status, with a
  separate tab for each status (pending, accepted, etc).
- Use the "Organize by" form in the sidebar to change how suggestions
  are listed. In each case confirm that the tabs are redisplayed
  correctly.

Works as advertised. 3/3

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 3 Katrin Fischer 2023-04-08 21:31:43 UTC
Patch doesn't apply, can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 33310: Use template wrapper for tabs: Suggestions
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 33310: Use template wrapper for tabs: Suggestions
Comment 4 Owen Leonard 2023-04-13 16:57:35 UTC
Created attachment 149614 [details] [review]
Bug 33310: Use template wrapper for tabs: Suggestions

This patch updates the suggestions template so that it uses the new
WRAPPER directive to build tabbed navigation.

To test, apply the patch and go to the suggestions page in the staff
interface.

- By default you suggestions should be organized by status, with a
  separate tab for each status (pending, accepted, etc).
- Use the "Organize by" form in the sidebar to change how suggestions
  are listed. In each case confirm that the tabs are redisplayed
  correctly.

Works as advertised. 3/3

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 5 Owen Leonard 2023-04-13 17:41:28 UTC
Created attachment 149618 [details] [review]
Bug 33310: Use template wrapper for tabs: Suggestions

This patch updates the suggestions template so that it uses the new
WRAPPER directive to build tabbed navigation.

To test, apply the patch and go to the suggestions page in the staff
interface.

- By default you suggestions should be organized by status, with a
  separate tab for each status (pending, accepted, etc).
- Use the "Organize by" form in the sidebar to change how suggestions
  are listed. In each case confirm that the tabs are redisplayed
  correctly.

Works as advertised. 3/3

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Katrin Fischer 2023-04-20 20:47:42 UTC
Created attachment 149993 [details] [review]
Bug 33310: Use template wrapper for tabs: Suggestions

This patch updates the suggestions template so that it uses the new
WRAPPER directive to build tabbed navigation.

To test, apply the patch and go to the suggestions page in the staff
interface.

- By default you suggestions should be organized by status, with a
  separate tab for each status (pending, accepted, etc).
- Use the "Organize by" form in the sidebar to change how suggestions
  are listed. In each case confirm that the tabs are redisplayed
  correctly.

Works as advertised. 3/3

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-04-21 13:37:33 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-05-10 12:54:41 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.