Bug 33324 - Use template wrapper for tabs: Tools
Summary: Use template wrapper for tabs: Tools
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks: 33637
  Show dependency treegraph
 
Reported: 2023-03-23 16:09 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33324: Use template wrapper for tabs: Tools (56.83 KB, patch)
2023-03-23 16:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33324: Use template wrapper for tabs: Tools (56.91 KB, patch)
2023-03-29 08:36 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33324: Use template wrapper for tabs: Tools (56.95 KB, patch)
2023-04-08 21:21 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-23 16:09:22 UTC
Continuing the work of Bug 32571, I would like to update three templates in the tools directory to use the new WRAPPER for tabs:

- Export
- Batch patron modification
- Overdue notice/status triggers
Comment 1 Owen Leonard 2023-03-23 16:26:17 UTC
Created attachment 148616 [details] [review]
Bug 33324: Use template wrapper for tabs: Tools

This patch updates templates in the tools directory so that they use
the new WRAPPER directive to build tabbed navigation.

To test, apply the patch and test each page to confirm that tabs still
work as before:

- Cataloging -> Export
  - This page by default will have two tabs, "Export bibliographic
    records" and "Export authority records." You can edit koha-conf.xml
    to enable two additional options: backup_db_via_tools and
    backup_conf_via_tools
- Tools -> Batch patron modification
  - "By card number" and "By borrowernumber," and "By patron list" if
    you have any patron lists defined.
- Tools -> Overdue notice/status triggers
Comment 2 Matt Blenkinsop 2023-03-29 08:36:00 UTC
Created attachment 148875 [details] [review]
Bug 33324: Use template wrapper for tabs: Tools

This patch updates templates in the tools directory so that they use
the new WRAPPER directive to build tabbed navigation.

To test, apply the patch and test each page to confirm that tabs still
work as before:

- Cataloging -> Export
  - This page by default will have two tabs, "Export bibliographic
    records" and "Export authority records." You can edit koha-conf.xml
    to enable two additional options: backup_db_via_tools and
    backup_conf_via_tools
- Tools -> Batch patron modification
  - "By card number" and "By borrowernumber," and "By patron list" if
    you have any patron lists defined.
- Tools -> Overdue notice/status triggers

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-04-08 21:21:36 UTC
Created attachment 149316 [details] [review]
Bug 33324: Use template wrapper for tabs: Tools

This patch updates templates in the tools directory so that they use
the new WRAPPER directive to build tabbed navigation.

To test, apply the patch and test each page to confirm that tabs still
work as before:

- Cataloging -> Export
  - This page by default will have two tabs, "Export bibliographic
    records" and "Export authority records." You can edit koha-conf.xml
    to enable two additional options: backup_db_via_tools and
    backup_conf_via_tools
- Tools -> Batch patron modification
  - "By card number" and "By borrowernumber," and "By patron list" if
    you have any patron lists defined.
- Tools -> Overdue notice/status triggers

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-12 14:22:54 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:46:16 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.