Bug 33328 - x-marc-schema should be renamed x-record-schema
Summary: x-marc-schema should be renamed x-record-schema
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 33227
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-23 22:29 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:

Attachments
Bug 33328: Rename x-marc-schema => x-record-schema (2.83 KB, patch)
2023-03-23 22:53 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 33328: Rename x-marc-schema => x-record-schema (2.99 KB, patch)
2023-04-14 11:44 UTC, Magnus Enger 		Details | Diff | Splinter Review
Bug 33328: Rename x-marc-schema => x-record-schema (3.06 KB, patch)
2023-05-02 08:01 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2023-03-23 22:29:11 UTC 
Before it is too late, we need to rename the HEADER param.
Comment 1 Tomás Cohen Arazi (tcohen) 2023-03-23 22:53:22 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2023-04-14 11:44:58 UTC 
Created attachment 149671 [details] [review]
Bug 33328: Rename x-marc-schema => x-record-schema

This patch renames the header on the biblio API so it is not entirely
tied to MARC, trying to follow the biblio_metadata table generic
approach.

To test:
1. Apply this patch
2. Run:
   $ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass
3. You agree with the change?
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Change sounds reasonable. Tests pass before and after patch.
"grep -r "x-marc-schema" *" confirms no occurrences after patch.
Comment 3 Martin Renvoize (ashimema) 2023-05-02 08:01:13 UTC 
Created attachment 150500 [details] [review]
Bug 33328: Rename x-marc-schema => x-record-schema

This patch renames the header on the biblio API so it is not entirely
tied to MARC, trying to follow the biblio_metadata table generic
approach.

To test:
1. Apply this patch
2. Run:
   $ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass
3. You agree with the change?
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Change sounds reasonable. Tests pass before and after patch.
"grep -r "x-marc-schema" *" confirms no occurrences after patch.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-05-02 08:01:50 UTC 
Trivial improvement, Passing QA
Comment 5 Tomás Cohen Arazi (tcohen) 2023-05-05 12:17:22 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-05-11 11:17:31 UTC 
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 7 Lucas Gass (lukeg) 2023-05-15 22:18:34 UTC 
Missing dependencies for 22.05.x, no backport.