Bug 33333 - Use template wrapper for tabs: SQL reports
Summary: Use template wrapper for tabs: SQL reports
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-24 17:16 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33333: Use template wrapper for tabs: SQL reports (5.18 KB, patch)
2023-03-24 17:27 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33333: Use template wrapper for tabs: SQL reports (5.24 KB, patch)
2023-03-27 12:04 UTC, PTFS Europe Sandboxes 		Details | Diff | Splinter Review
Bug 33333: Use template wrapper for tabs: SQL reports (5.30 KB, patch)
2023-04-08 21:13 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-24 17:16:32 UTC 
Continuing the work of Bug 32571, I would like to update the saved SQL reports page in the staff client to use the new WRAPPER for tabs
Comment 1 Owen Leonard 2023-03-24 17:27:45 UTC 
Created attachment 148686 [details] [review]
Bug 33333: Use template wrapper for tabs: SQL reports

This patch updates the saved SQL reports template so that it uses the
new WRAPPER directive to build tab markup.

To test, apply the patch and go to Reports -> Use saved. In order to
properly test the patch you should have multiple reports defined with
multiple categories ("Accounts", "Acquisitions", "Catalog", etc.).

Clicking each tab should filter the table of reports correctly.
After navigating away from the page and back to it, your selected tab
should be remembered.
Comment 2 PTFS Europe Sandboxes 2023-03-27 12:04:49 UTC 
Created attachment 148756 [details] [review]
Bug 33333: Use template wrapper for tabs: SQL reports

This patch updates the saved SQL reports template so that it uses the
new WRAPPER directive to build tab markup.

To test, apply the patch and go to Reports -> Use saved. In order to
properly test the patch you should have multiple reports defined with
multiple categories ("Accounts", "Acquisitions", "Catalog", etc.).

Clicking each tab should filter the table of reports correctly.
After navigating away from the page and back to it, your selected tab
should be remembered.

Signed-off-by: Alexandra Speer <alexandra.speer@bsz-bw.de>
Comment 3 Katrin Fischer 2023-04-08 21:13:20 UTC 
Created attachment 149314 [details] [review]
Bug 33333: Use template wrapper for tabs: SQL reports

This patch updates the saved SQL reports template so that it uses the
new WRAPPER directive to build tab markup.

To test, apply the patch and go to Reports -> Use saved. In order to
properly test the patch you should have multiple reports defined with
multiple categories ("Accounts", "Acquisitions", "Catalog", etc.).

Clicking each tab should filter the table of reports correctly.
After navigating away from the page and back to it, your selected tab
should be remembered.

Signed-off-by: Alexandra Speer <alexandra.speer@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-12 14:23:02 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:46:19 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.