Created attachment 148731 [details] English 1-page order PDF covering multiple pages with page number obscured and table starting halfway down second page Currently, when a basket group contains a lot of ordered items (more than be listed on one page) the following happens: - The page numbers at the bottom of the first page are obscured. - The table on the second page starts halfway down the page. See the attachment as an example. We would like the page numbers on the first page to be visible, and the table to start near the top of the second (and all subsequent pages).
Created attachment 148732 [details] [review] Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages If a basket group contains many ordered items then this patchset will ensure: - The page number at the bottom of the first page is not obscured - The table of ordered items does not start half way down the second page Test plan: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 5, 6, 7 and 8 9) If the PDF is multiple pages long then confirm: - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 10) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College
Created attachment 148733 [details] English 1-page order PDF covering multiple pages with formatting fixed - The page numbers at the bottom of the first page not obscured - The table starts near the top of the second page
Ready for testing
Created attachment 148764 [details] [review] Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages If a basket group contains many ordered items then this patchset will ensure: - The page number at the bottom of the first page is not obscured - The table of ordered items does not start half way down the second page Test plan: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 5, 6, 7 and 8 9) If the PDF is multiple pages long then confirm: - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 10) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 150384 [details] [review] Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages If a basket group contains many ordered items then this patchset will ensure: - The page number at the bottom of the first page is not obscured - The table of ordered items does not start half way down the second page Test plan: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 5, 6, 7 and 8 9) If the PDF is multiple pages long then confirm: - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 10) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Thank you Tomás! Could we please request that this enhancement be backported to 22.11.x? Our client who sponsored the enhancement would love to benefit from having it sooner than their next major upgrade in Jan-March next year.
Nice work everyone! Pushed to 22.11.x for next release
Thank you very much indeed for backporting this to 22.11.x. It is hugely appreciated by us and the client who sponsored it.