Bug 33346 - Add Help link to Koha manual in ERM module
Summary: Add Help link to Koha manual in ERM module
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: 22.11
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords: rel_22_11_candidate
Depends on:
Blocks:
 
Reported: 2023-03-27 21:43 UTC by Catrina Berka
Modified: 2023-12-01 15:41 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33346: Add Help link to Koha manual in ERM module (5.53 KB, patch)
2023-03-28 08:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33346: Add Help link to Koha manual in ERM module (5.58 KB, patch)
2023-03-28 09:49 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33346: Add missing class and id to link (970 bytes, patch)
2023-03-28 09:49 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33346: Add Help link to Koha manual in ERM module (5.64 KB, patch)
2023-03-28 12:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33346: Add missing class and id to link (1.01 KB, patch)
2023-03-28 12:55 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Catrina Berka 2023-03-27 21:43:28 UTC
All other pages/modules in Koha show the Help button hyperlinked to the relevant portion of the manual. This link is missing throughout the ERM module and should be added in.
Comment 1 Jonathan Druart 2023-03-28 08:16:16 UTC
Created attachment 148794 [details] [review]
Bug 33346: Add Help link to Koha manual in ERM module

The 'Help' is missing in the ERM module, this patch is adding it.

Test plan:
Confirm that the Help link is displayed on the different pages of the
ERM module and that it leads to the correct page of the manual.
Comment 2 Pedro Amorim 2023-03-28 09:49:14 UTC
Created attachment 148807 [details] [review]
Bug 33346: Add Help link to Koha manual in ERM module

The 'Help' is missing in the ERM module, this patch is adding it.

Test plan:
Confirm that the Help link is displayed on the different pages of the
ERM module and that it leads to the correct page of the manual.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Pedro Amorim 2023-03-28 09:49:17 UTC
Created attachment 148808 [details] [review]
Bug 33346: Add missing class and id to link

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-03-28 12:55:22 UTC
Created attachment 148819 [details] [review]
Bug 33346: Add Help link to Koha manual in ERM module

The 'Help' is missing in the ERM module, this patch is adding it.

Test plan:
Confirm that the Help link is displayed on the different pages of the
ERM module and that it leads to the correct page of the manual.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-03-28 12:55:26 UTC
Created attachment 148820 [details] [review]
Bug 33346: Add missing class and id to link

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2023-03-28 12:56:09 UTC
All working, thanks. Passing QA
Comment 7 Tomás Cohen Arazi 2023-03-31 10:18:07 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 David Cook 2023-04-03 23:57:38 UTC
Any chance of this getting backported to 22.11 as well?
Comment 9 Katrin Fischer 2023-04-04 09:14:03 UTC
(In reply to David Cook from comment #8)
> Any chance of this getting backported to 22.11 as well?

I'd say this is more a bug than an enhancement - the links should appear on all pages. ;)
Comment 10 Matt Blenkinsop 2023-04-11 11:25:11 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 11 Lucas Gass 2023-04-24 17:22:16 UTC
Not needed in 22.05.x, no backport.