Bug 33355 - ERM UI and markup has some issues
Summary: ERM UI and markup has some issues
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Pedro Amorim
QA Contact:
URL:
Keywords:
: 33542 (view as bug list)
Depends on: 32931 33103
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-29 08:38 UTC by Pedro Amorim
Modified: 2023-07-03 16:07 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd (2.61 KB, patch)
2023-03-29 08:47 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Update forms markup to be in line with interface patterns (8.94 KB, patch)
2023-03-29 08:47 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Tidyness for forms markup, squash this later (27.51 KB, patch)
2023-03-29 08:47 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content (1.89 KB, patch)
2023-03-29 08:47 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd (2.61 KB, patch)
2023-03-29 15:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Update forms markup to be in line with interface patterns (32.23 KB, patch)
2023-03-29 15:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content (1.90 KB, patch)
2023-03-29 15:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd (2.68 KB, patch)
2023-04-04 07:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33355: Update forms markup to be in line with interface patterns (32.30 KB, patch)
2023-04-04 07:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content (1.97 KB, patch)
2023-04-04 07:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Screenshot before patch 149117 and the problems it fixes (86.21 KB, image/jpeg)
2023-04-17 17:00 UTC, Pedro Amorim
Details
Screenshot before patch 149118 and the problems it fixes (75.17 KB, image/jpeg)
2023-04-17 17:00 UTC, Pedro Amorim
Details
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd (2.75 KB, patch)
2023-04-19 12:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33355: Update forms markup to be in line with interface patterns (32.35 KB, patch)
2023-04-19 12:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content (2.03 KB, patch)
2023-04-19 12:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd (2.75 KB, patch)
2023-04-21 14:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Update forms markup to be in line with interface patterns (33.02 KB, patch)
2023-04-21 14:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content (2.03 KB, patch)
2023-04-21 14:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd (2.75 KB, patch)
2023-04-24 15:15 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Update forms markup to be in line with interface patterns (32.38 KB, patch)
2023-04-24 15:15 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content (2.03 KB, patch)
2023-04-24 15:15 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd (3.49 KB, patch)
2023-05-05 14:15 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Update forms markup to be in line with interface patterns (32.44 KB, patch)
2023-05-05 14:15 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content (2.03 KB, patch)
2023-05-05 14:15 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-03-29 08:38:08 UTC

    
Comment 1 Pedro Amorim 2023-03-29 08:47:20 UTC
Created attachment 148885 [details] [review]
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd
Comment 2 Pedro Amorim 2023-03-29 08:47:23 UTC
Created attachment 148886 [details] [review]
Bug 33355: Update forms markup to be in line with interface patterns

https://wiki.koha-community.org/wiki/Interface_patterns
Comment 3 Pedro Amorim 2023-03-29 08:47:27 UTC
Created attachment 148887 [details] [review]
Bug 33355: Tidyness for forms markup, squash this later
Comment 4 Pedro Amorim 2023-03-29 08:47:29 UTC
Created attachment 148888 [details] [review]
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content
Comment 5 Pedro Amorim 2023-03-29 08:48:44 UTC
Cypress tests are happy
Comment 6 Pedro Amorim 2023-03-29 15:21:12 UTC
Created attachment 148934 [details] [review]
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd
Comment 7 Pedro Amorim 2023-03-29 15:21:15 UTC
Created attachment 148935 [details] [review]
Bug 33355: Update forms markup to be in line with interface patterns

https://wiki.koha-community.org/wiki/Interface_patterns
Comment 8 Pedro Amorim 2023-03-29 15:21:18 UTC
Created attachment 148936 [details] [review]
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content
Comment 9 Jonathan Druart 2023-04-04 07:36:12 UTC
Created attachment 149116 [details] [review]
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2023-04-04 07:36:15 UTC
Created attachment 149117 [details] [review]
Bug 33355: Update forms markup to be in line with interface patterns

https://wiki.koha-community.org/wiki/Interface_patterns

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Jonathan Druart 2023-04-04 07:36:17 UTC
Created attachment 149118 [details] [review]
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Christian Stelzenmüller 2023-04-17 09:05:26 UTC
*** Bug 33542 has been marked as a duplicate of this bug. ***
Comment 13 Caroline Cyr La Rose 2023-04-17 15:09:33 UTC
It would help to have a test plan to know what is supposed to be corrected. I came here because of the 'is perpetual' thing, but I'm not sure what the other commits do
Comment 14 Pedro Amorim 2023-04-17 17:00:03 UTC
Created attachment 149760 [details]
Screenshot before patch 149117 and the problems it fixes
Comment 15 Pedro Amorim 2023-04-17 17:00:32 UTC
Created attachment 149761 [details]
Screenshot before patch 149118 and the problems it fixes
Comment 16 Pedro Amorim 2023-04-17 17:02:18 UTC
(In reply to Caroline Cyr La Rose from comment #13)
> It would help to have a test plan to know what is supposed to be corrected.
> I came here because of the 'is perpetual' thing, but I'm not sure what the
> other commits do

Hi Caroline, thank you so much for looking into this.
Apologies for not being clear enough. Please take a look at the screenshots I attached, I hope those help in explaining the problems and respective fixes.
Comment 17 Martin Renvoize 2023-04-19 12:51:56 UTC
Created attachment 149883 [details] [review]
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 18 Martin Renvoize 2023-04-19 12:51:59 UTC
Created attachment 149884 [details] [review]
Bug 33355: Update forms markup to be in line with interface patterns

https://wiki.koha-community.org/wiki/Interface_patterns

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 19 Martin Renvoize 2023-04-19 12:52:02 UTC
Created attachment 149885 [details] [review]
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 20 Martin Renvoize 2023-04-19 12:52:50 UTC
Something in me doesn't really like the fieldset nesting this introduces.. but display wise it's working well.

Code is all working after the changes, Passing QA
Comment 21 Pedro Amorim 2023-04-21 14:23:35 UTC
Created attachment 150043 [details] [review]
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 22 Pedro Amorim 2023-04-21 14:23:38 UTC
Created attachment 150044 [details] [review]
Bug 33355: Update forms markup to be in line with interface patterns

https://wiki.koha-community.org/wiki/Interface_patterns

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 23 Pedro Amorim 2023-04-21 14:23:41 UTC
Created attachment 150045 [details] [review]
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 24 Pedro Amorim 2023-04-24 15:15:24 UTC
Created attachment 150163 [details] [review]
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 25 Pedro Amorim 2023-04-24 15:15:27 UTC
Created attachment 150164 [details] [review]
Bug 33355: Update forms markup to be in line with interface patterns

https://wiki.koha-community.org/wiki/Interface_patterns

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 26 Pedro Amorim 2023-04-24 15:15:30 UTC
Created attachment 150165 [details] [review]
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 27 Tomás Cohen Arazi 2023-05-05 13:04:33 UTC
Please rebase ASAP.
Comment 28 Pedro Amorim 2023-05-05 14:15:03 UTC
Created attachment 150759 [details] [review]
Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 29 Pedro Amorim 2023-05-05 14:15:06 UTC
Created attachment 150760 [details] [review]
Bug 33355: Update forms markup to be in line with interface patterns

https://wiki.koha-community.org/wiki/Interface_patterns

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 30 Pedro Amorim 2023-05-05 14:15:09 UTC
Created attachment 150761 [details] [review]
Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 31 Tomás Cohen Arazi 2023-05-05 15:14:55 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 32 Matt Blenkinsop 2023-05-15 14:12:49 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 33 Lucas Gass 2023-06-15 19:44:22 UTC
Missing dependencies for 22.05.x, no backport