Bug 33373 - Use template wrapper for breadcrumbs: Circulation part 3
Summary: Use template wrapper for breadcrumbs: Circulation part 3
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-30 19:14 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 (11.38 KB, patch)
2023-03-31 12:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 (11.44 KB, patch)
2023-04-03 14:45 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 (11.49 KB, patch)
2023-04-08 21:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-30 19:14:41 UTC
To continue the process started by Bug 32507, this patch will update more circulation templates so that they use the new template wrapper for breadcrumbs.

 - circ/request-article.tt
 - circ/reserveratios.tt
 - circ/returns.tt
 - circ/set-library.tt
 - circ/transfers_to_send.tt
 - circ/transferstoreceive.tt
 - circ/view_holdsqueue.tt
 - circ/waitingreserves.tt
Comment 1 Owen Leonard 2023-03-31 12:41:21 UTC Comment hidden (obsolete)
Comment 2 Andrew Auld 2023-03-31 17:08:04 UTC
I can't complete this test as the 'Hold ratios' link throws the following error:

CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl::reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed: 'koha_bug33158.reserves.reservedate' isn't in GROUP BY at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
Comment 3 Andrew Auld 2023-03-31 17:08:29 UTC
Everything else is tested and is fine for sign-off
Comment 4 Owen Leonard 2023-03-31 17:40:06 UTC
(In reply to Andrew Auld from comment #2)
> I can't complete this test as the 'Hold ratios' link throws the following
> error:
> 
> CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl::
> reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed

There is a bug with the hold ratios report when SQL mode is set to "Strict," which you can get around if you have access to editing koha-conf.xml bug not if you're using a sandbox
Comment 5 Andrew Auld 2023-03-31 17:47:04 UTC
Aha, sorry. I am using sandboxes. I'll have to leave to someone able to test not on a sandbox.

As I say, the rest works.
Comment 6 Lucas Gass 2023-04-03 14:45:55 UTC
Created attachment 149098 [details] [review]
Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation ->
  - Article requests -> Article request detail
  - Check in
  - Hold ratios
  - Transfers to send
  - Transfers to receive
  - Holds queue
  - Holds awaiting pickup
  - Set library

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Katrin Fischer 2023-04-08 21:04:00 UTC
Created attachment 149312 [details] [review]
Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation ->
  - Article requests -> Article request detail
  - Check in
  - Hold ratios
  - Transfers to send
  - Transfers to receive
  - Holds queue
  - Holds awaiting pickup
  - Set library

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi 2023-04-12 14:44:42 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Jacob O'Mara 2023-04-16 20:38:13 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.