To continue the process started by Bug 32507, this patch will update more circulation templates so that they use the new template wrapper for breadcrumbs. - circ/request-article.tt - circ/reserveratios.tt - circ/returns.tt - circ/set-library.tt - circ/transfers_to_send.tt - circ/transferstoreceive.tt - circ/view_holdsqueue.tt - circ/waitingreserves.tt
Created attachment 149036 [details] [review] Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation -> - Article requests -> Article request detail - Check in - Hold ratios - Transfers to send - Transfers to receive - Holds queue - Holds awaiting pickup - Set library
I can't complete this test as the 'Hold ratios' link throws the following error: CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl::reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed: 'koha_bug33158.reserves.reservedate' isn't in GROUP BY at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
Everything else is tested and is fine for sign-off
(In reply to Andrew Auld from comment #2) > I can't complete this test as the 'Hold ratios' link throws the following > error: > > CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl:: > reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed There is a bug with the hold ratios report when SQL mode is set to "Strict," which you can get around if you have access to editing koha-conf.xml bug not if you're using a sandbox
Aha, sorry. I am using sandboxes. I'll have to leave to someone able to test not on a sandbox. As I say, the rest works.
Created attachment 149098 [details] [review] Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation -> - Article requests -> Article request detail - Check in - Hold ratios - Transfers to send - Transfers to receive - Holds queue - Holds awaiting pickup - Set library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 149312 [details] [review] Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation -> - Article requests -> Article request detail - Check in - Hold ratios - Transfers to send - Transfers to receive - Holds queue - Holds awaiting pickup - Set library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.