Bug 33379 - virtualshelfcontents.flags seems useless
Summary: virtualshelfcontents.flags seems useless
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-31 07:53 UTC by Jonathan Druart
Modified: 2023-10-14 12:31 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch set drops the column virtualshelfcontents.flag which is unused for a long time.
Version(s) released in:
23.11.00


Attachments
Bug 33379: Remove virtualshelfcontents.flags (2.40 KB, patch)
2023-06-27 14:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33379: DBIx changes (1.59 KB, patch)
2023-06-27 14:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33379: Remove virtualshelfcontents.flags (2.41 KB, patch)
2023-06-27 19:09 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33379: DBIx changes (1.61 KB, patch)
2023-06-27 19:09 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33379: Remove virtualshelfcontents.flags (2.49 KB, patch)
2023-07-04 10:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33379: DBIx changes (1.68 KB, patch)
2023-07-04 10:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33379: (QA follow-up) Tidy dbrev (1.10 KB, patch)
2023-07-20 11:52 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-03-31 07:53:09 UTC
Looks like we should remove this column, it's not used.
Comment 1 Marcel de Rooy 2023-06-27 14:43:39 UTC
Created attachment 152749 [details] [review]
Bug 33379: Remove virtualshelfcontents.flags

This field is unused. A historic leftover from 2000-2010.

Test plan:
Run dbrev.
Run prove t/db_dependent/Koha/Virtualshel*

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-06-27 14:43:41 UTC
Created attachment 152750 [details] [review]
Bug 33379: DBIx changes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Lucas Gass 2023-06-27 19:09:50 UTC
Created attachment 152770 [details] [review]
Bug 33379: Remove virtualshelfcontents.flags

This field is unused. A historic leftover from 2000-2010.

Test plan:
Run dbrev.
Run prove t/db_dependent/Koha/Virtualshel*

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass 2023-06-27 19:09:53 UTC
Created attachment 152771 [details] [review]
Bug 33379: DBIx changes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Jonathan Druart 2023-07-04 10:27:15 UTC
Created attachment 153010 [details] [review]
Bug 33379: Remove virtualshelfcontents.flags

This field is unused. A historic leftover from 2000-2010.

Test plan:
Run dbrev.
Run prove t/db_dependent/Koha/Virtualshel*

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2023-07-04 10:27:18 UTC
Created attachment 153011 [details] [review]
Bug 33379: DBIx changes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2023-07-04 10:28:42 UTC
We could test if the column is empty, but this leads to problem in the past. I am in favor of dropping the column.

There are release notes and backups to prevent data loss.
Comment 8 Marcel de Rooy 2023-07-14 06:27:38 UTC Comment hidden (obsolete)
Comment 9 Marcel de Rooy 2023-07-20 11:52:55 UTC
Created attachment 153718 [details] [review]
Bug 33379: (QA follow-up) Tidy dbrev

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Marcel de Rooy 2023-07-20 11:53:42 UTC
 OK     Koha/Schema/Result/Virtualshelfcontent.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     installer/data/mysql/atomicupdate/bug33379.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     installer/data/mysql/kohastructure.sql
   OK     boolean_vs_tinyint
   OK     charset_collate
   OK     git manipulation
   OK     tinyint_has_boolean_flag
Comment 11 Tomás Cohen Arazi 2023-07-20 16:03:33 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 12 Fridolin Somers 2023-08-04 01:52:02 UTC
Enhancement not pushed to 23.05.x