Bug 33382 - Use template wrapper for breadcrumbs: Patron clubs
Summary: Use template wrapper for breadcrumbs: Patron clubs
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-31 13:32 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33382: Use template wrapper for breadcrumbs: Patron clubs (7.99 KB, patch)
2023-03-31 13:40 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33382: Use template wrapper for breadcrumbs: Patron clubs (8.05 KB, patch)
2023-03-31 15:46 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 33382: Use template wrapper for breadcrumbs: Patron clubs (8.10 KB, patch)
2023-04-08 21:00 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-31 13:32:42 UTC 
To continue the process started by Bug 32507, this patch will update patron club templates so that they use the new template wrapper for breadcrumbs.

- clubs/club-enrollments.tt
- clubs/clubs-add-modify.tt
- clubs/clubs.tt
- clubs/templates-add-modify.tt
Comment 1 Owen Leonard 2023-03-31 13:40:12 UTC 
Created attachment 149037 [details] [review]
Bug 33382: Use template wrapper for breadcrumbs: Patron clubs

This patch updates patron club templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron clubs
    - New club template
    - Edit club template
    - New club
    - Edit club
    - Club enrollments (from the "Actions" menu in the list of clubs)
Comment 2 ByWater Sandboxes 2023-03-31 15:46:48 UTC 
Created attachment 149043 [details] [review]
Bug 33382: Use template wrapper for breadcrumbs: Patron clubs

This patch updates patron club templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron clubs
    - New club template
    - Edit club template
    - New club
    - Edit club
    - Club enrollments (from the "Actions" menu in the list of clubs)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-04-08 21:00:46 UTC 
Created attachment 149311 [details] [review]
Bug 33382: Use template wrapper for breadcrumbs: Patron clubs

This patch updates patron club templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron clubs
    - New club template
    - Edit club template
    - New club
    - Edit club
    - Club enrollments (from the "Actions" menu in the list of clubs)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-12 14:44:46 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:38:17 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.