Bug 33384 - Use template wrapper for breadcrumbs: Labels
Summary: Use template wrapper for breadcrumbs: Labels
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-31 15:30 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33384: Use template wrapper for breadcrumbs: Labels (17.81 KB, patch)
2023-03-31 15:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33384: Use template wrapper for breadcrumbs: Labels (17.87 KB, patch)
2023-03-31 17:55 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33384: Use template wrapper for breadcrumbs: Labels (17.92 KB, patch)
2023-04-08 20:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-31 15:30:39 UTC
To continue the process started by Bug 32507, this patch will update label creator templates so that they use the new template wrapper for breadcrumbs.

 - labels/barcode-print.tt
 - labels/label-edit-batch.tt
 - labels/label-edit-layout.tt
 - labels/label-edit-profile.tt
 - labels/label-edit-range.tt
 - labels/label-edit-template.tt
 - labels/label-home.tt
 - labels/label-manage.tt
 - labels/spinelabel-home.tt
Comment 1 Owen Leonard 2023-03-31 15:48:55 UTC
Created attachment 149044 [details] [review]
Bug 33384: Use template wrapper for breadcrumbs: Labels

This patch updates label creator templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Cataloging ->
  - Barcode image generator
  - Quick spine label creator
  - Label creator ->
    - Label creator home
      - New ->
        - Label batch
        - Layout
        - Label template
        - Printer profile
        - Barcode range
      - Manage ->
        - Label batches
          - Edit batch
        - Layouts
          - Edit layout
        - Label templates
          - Edit template
        - Printer profiles
Comment 2 PTFS Europe Sandboxes 2023-03-31 17:55:55 UTC
Created attachment 149051 [details] [review]
Bug 33384: Use template wrapper for breadcrumbs: Labels

This patch updates label creator templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Cataloging ->
  - Barcode image generator
  - Quick spine label creator
  - Label creator ->
    - Label creator home
      - New ->
        - Label batch
        - Layout
        - Label template
        - Printer profile
        - Barcode range
      - Manage ->
        - Label batches
          - Edit batch
        - Layouts
          - Edit layout
        - Label templates
          - Edit template
        - Printer profiles

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-03-31 17:56:29 UTC
Lovely!
Comment 4 Katrin Fischer 2023-04-08 20:56:15 UTC
Created attachment 149308 [details] [review]
Bug 33384: Use template wrapper for breadcrumbs: Labels

This patch updates label creator templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Cataloging ->
  - Barcode image generator
  - Quick spine label creator
  - Label creator ->
    - Label creator home
      - New ->
        - Label batch
        - Layout
        - Label template
        - Printer profile
        - Barcode range
      - Manage ->
        - Label batches
          - Edit batch
        - Layouts
          - Edit layout
        - Label templates
          - Edit template
        - Printer profiles

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-04-12 12:28:00 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:38:23 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.