Bug 33386 - Use template wrapper for breadcrumbs: Patrons part 2
Summary: Use template wrapper for breadcrumbs: Patrons part 2
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-31 16:33 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33386: Use template wrapper for breadcrumbs: Patrons part 2 (7.93 KB, patch)
2023-03-31 18:13 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33386: Use template wrapper for breadcrumbs: Patrons part 2 (7.99 KB, patch)
2023-03-31 21:43 UTC, PTFS Europe Sandboxes 		Details | Diff | Splinter Review
Bug 33386: Use template wrapper for breadcrumbs: Patrons part 2 (8.04 KB, patch)
2023-04-08 20:46 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-31 16:33:44 UTC 
To continue the process started by Bug 32507, this patch will update more patron module templates so that they use the new template wrapper for breadcrumbs.

- members/discharges.tt
- members/files.tt
- members/holdshistory.tt
- members/housebound.tt
- members/ill-requests.tt
Comment 1 Owen Leonard 2023-03-31 18:13:02 UTC 
Created attachment 149052 [details] [review]
Bug 33386: Use template wrapper for breadcrumbs: Patrons part 2

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patron details ->
  - Files (EnableBorrowerFiles must be enabled)
  - Holds history
  - Housebound (HouseboundModule must be enabled)
  - Ill requests history (ILLModule must be enabled)
- Staff interface home page -> Discharge requests pending
  - Must have useDischarge preference enabled
  - Must log into the OPAC and request a discharge using a patron
    account which has no checkouts.
Comment 2 PTFS Europe Sandboxes 2023-03-31 21:43:17 UTC 
Created attachment 149057 [details] [review]
Bug 33386: Use template wrapper for breadcrumbs: Patrons part 2

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patron details ->
  - Files (EnableBorrowerFiles must be enabled)
  - Holds history
  - Housebound (HouseboundModule must be enabled)
  - Ill requests history (ILLModule must be enabled)
- Staff interface home page -> Discharge requests pending
  - Must have useDischarge preference enabled
  - Must log into the OPAC and request a discharge using a patron
    account which has no checkouts.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-03-31 21:43:46 UTC 
Nice one!
Comment 4 Katrin Fischer 2023-04-08 20:46:59 UTC 
Created attachment 149306 [details] [review]
Bug 33386: Use template wrapper for breadcrumbs: Patrons part 2

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patron details ->
  - Files (EnableBorrowerFiles must be enabled)
  - Holds history
  - Housebound (HouseboundModule must be enabled)
  - Ill requests history (ILLModule must be enabled)
- Staff interface home page -> Discharge requests pending
  - Must have useDischarge preference enabled
  - Must log into the OPAC and request a discharge using a patron
    account which has no checkouts.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-04-12 12:28:08 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:38:30 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.