Bug 33388 - Use template wrapper for breadcrumbs: Patrons part 4
Summary: Use template wrapper for breadcrumbs: Patrons part 4
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-31 16:36 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 (11.26 KB, patch)
2023-04-04 12:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 (11.27 KB, patch)
2023-04-07 13:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 (11.33 KB, patch)
2023-04-13 13:25 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 (11.38 KB, patch)
2023-04-20 20:43 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-31 16:36:21 UTC
To continue the process started by Bug 32507, this patch will update more patron module templates so that they use the new template wrapper for breadcrumbs.

- members/memberentrygen.tt
- members/members-update.tt
- members/merge-patrons.tt
- members/moremember.tt
- members/notices.tt
- members/pay.tt
Comment 1 Owen Leonard 2023-04-04 12:13:42 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass 2023-04-04 22:14:48 UTC
On members/moremember.tt the link in the breadcrumbs is missing the borrowernumber and results in a "Patron not found".

- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]">
+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron.borrowernumber | uri %]">
Comment 3 Owen Leonard 2023-04-07 13:11:29 UTC
Created attachment 149275 [details] [review]
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patrons ->
  - Patron details
    - Notices
    - Accounting
  - Edit patron
  - Add patron
  - Patrons requesting modification (submit patron update via the OPAC)
Comment 4 Andrew Auld 2023-04-11 09:07:50 UTC
Patron details link not working:
/members/moremember.pl?borrowernumber=#
Comment 5 Owen Leonard 2023-04-13 13:02:05 UTC
(In reply to Andrew Auld from comment #4)
> Patron details link not working:
> /members/moremember.pl?borrowernumber=#

This looks to me like it is working. Could you re-test?
Comment 6 PTFS Europe Sandboxes 2023-04-13 13:25:04 UTC
Created attachment 149600 [details] [review]
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patrons ->
  - Patron details
    - Notices
    - Accounting
  - Edit patron
  - Add patron
  - Patrons requesting modification (submit patron update via the OPAC)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 7 Andrew Auld 2023-04-13 13:26:22 UTC
This is now signed off.
However I did spot an alignment issue on the Update Patron Records page for which I have created a new bug number #33520.
Comment 9 Katrin Fischer 2023-04-20 20:43:59 UTC
Created attachment 149992 [details] [review]
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patrons ->
  - Patron details
    - Notices
    - Accounting
  - Edit patron
  - Add patron
  - Patrons requesting modification (submit patron update via the OPAC)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2023-04-21 13:37:36 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 11 Jacob O'Mara 2023-05-10 12:54:44 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.