Bug 33389 - Use template wrapper for breadcrumbs: Patrons part 5
Summary: Use template wrapper for breadcrumbs: Patrons part 5
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-31 16:37 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33389: Use template wrapper for breadcrumbs: Patrons part 5 (11.24 KB, patch)
2023-04-04 14:45 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33389: Use template wrapper for breadcrumbs: Patrons part 5 (11.29 KB, patch)
2023-04-04 22:23 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 33389: Use template wrapper for breadcrumbs: Patrons part 5 (11.35 KB, patch)
2023-04-08 20:32 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-31 16:37:27 UTC 
To continue the process started by Bug 32507, this patch will update more patron module templates so that they use the new template wrapper for breadcrumbs.

- members/paycollect.tt
- members/purchase-suggestions.tt
- members/readingrec.tt
- members/routing-lists.tt
- members/statistics.tt
- members/two_factor_auth.tt
Comment 1 Owen Leonard 2023-04-04 14:45:17 UTC 
Created attachment 149129 [details] [review]
Bug 33389: Use template wrapper for breadcrumbs: Patrons part 5

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patrons ->
  - Patron details ->
    (Patron with charges) ->
      - Accounting ->
        - Pay
    - Circulation history
    - Routing lists
    - Statistics
    - Purchase suggestions
    - More -> Manage two-factor authentication (must have
      TwoFactorAuthentication enabled)
Comment 2 Lucas Gass (lukeg) 2023-04-04 22:23:23 UTC 
Created attachment 149147 [details] [review]
Bug 33389: Use template wrapper for breadcrumbs: Patrons part 5

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patrons ->
  - Patron details ->
    (Patron with charges) ->
      - Accounting ->
        - Pay
    - Circulation history
    - Routing lists
    - Statistics
    - Purchase suggestions
    - More -> Manage two-factor authentication (must have
      TwoFactorAuthentication enabled)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-04-08 20:32:34 UTC 
Created attachment 149304 [details] [review]
Bug 33389: Use template wrapper for breadcrumbs: Patrons part 5

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patrons ->
  - Patron details ->
    (Patron with charges) ->
      - Accounting ->
        - Pay
    - Circulation history
    - Routing lists
    - Statistics
    - Purchase suggestions
    - More -> Manage two-factor authentication (must have
      TwoFactorAuthentication enabled)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-12 12:28:16 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:38:36 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.