Bug 33390 - Expand links to authorized values interface when an authval is mentioned in preferences
Summary: Expand links to authorized values interface when an authval is mentioned in p...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-31 17:29 UTC by Catrina Berka
Modified: 2023-11-10 21:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33390: Add links to various system preference descriptions (9.78 KB, patch)
2023-04-03 21:12 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33390: Add links to various system preference descriptions (9.84 KB, patch)
2023-04-03 21:53 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place (1.79 KB, patch)
2023-04-24 23:01 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33390: Add links to various system preference descriptions (9.92 KB, patch)
2023-05-09 21:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place (1.80 KB, patch)
2023-05-09 21:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33390: (QA follow-up) Rephrase some preferences (6.52 KB, patch)
2023-05-09 21:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33390: Add links to various system preference descriptions (10.96 KB, patch)
2023-11-01 17:15 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place (1.80 KB, patch)
2023-11-01 17:15 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33390: (QA follow-up) Rephrase some preferences (6.52 KB, patch)
2023-11-01 17:15 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33390: Add links to various system preference descriptions (10.96 KB, patch)
2023-11-01 18:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place (1.80 KB, patch)
2023-11-01 18:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33390: (QA follow-up) Rephrase some preferences (6.52 KB, patch)
2023-11-01 18:09 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Catrina Berka 2023-03-31 17:29:16 UTC
Bug 31730 introduced the functionality to link from a mentioned authorized value to the corresponding authorized value page, showing which values are available to use when setting that system preference. This feature should be consistently available across system preferences, not just those that had been mentioned in the bug. Other system preferences that should be updated with this functionality are listed below. 

Lost (LOST):
DefaultLongOverdueChargeValue
DefaultLongOverdueLostValue and DefaultLongOverdueDays
DefaultLongOverdueSkipLostStatuses
UpdateItemWhenLostFromHoldList

Shelving Location (LOC):
NewItemsDefaultLocation
UpdateItemLocationOnCheckin

Not for Loan (NOT_LOAN):
SkipHoldTrapOnNotForLoanValue
UpdateNotForLoanStatusOnCheckin
Reference_NFL_Statuses

Several authorized values:
ItemsDeniedRenewal
Comment 1 Lucas Gass 2023-04-03 21:12:02 UTC
Created attachment 149109 [details] [review]
Bug 33390: Add links to various system preference descriptions

To test:
1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense:

DefaultLongOverdueChargeValue
DefaultLongOverdueLostValue and DefaultLongOverdueDays
DefaultLongOverdueSkipLostStatuses
UpdateItemWhenLostFromHoldList

NewItemsDefaultLocation
UpdateItemLocationOnCheckin

SkipHoldTrapOnNotForLoanValue
UpdateNotForLoanStatusOnCheckin
Reference_NFL_Statuses

ItemsDeniedRenewal
Comment 2 ByWater Sandboxes 2023-04-03 21:53:05 UTC
Created attachment 149110 [details] [review]
Bug 33390: Add links to various system preference descriptions

To test:
1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense:

DefaultLongOverdueChargeValue
DefaultLongOverdueLostValue and DefaultLongOverdueDays
DefaultLongOverdueSkipLostStatuses
UpdateItemWhenLostFromHoldList

NewItemsDefaultLocation
UpdateItemLocationOnCheckin

SkipHoldTrapOnNotForLoanValue
UpdateNotForLoanStatusOnCheckin
Reference_NFL_Statuses

ItemsDeniedRenewal

Signed-off-by: Catrina <catrina@bywatersolutions.com>
Comment 3 Catrina Berka 2023-04-03 21:54:46 UTC
Thank you, Lucas! This is exactly right and the patch works as expected.
Comment 4 David Nind 2023-04-04 18:02:56 UTC
Hi Catrina.

To complete the sign off, you need to change the status from "Needs Signoff" to "Signed Off".

Then you will get the credit on the dashboard (https://dashboard.koha-community.org/). 8-)

David
Comment 5 Catrina Berka 2023-04-04 18:08:00 UTC
I appreciate your help, David! Just changed it.
Comment 6 Katrin Fischer 2023-04-23 22:04:43 UTC
Looking at this and as I won't finish right now, leaving a first note:

ItemsDeniedRenewal: I feel the placement of the links right after the examples you can copy and paste is not ideal. Maybe we could put them into an explanatory sentence below?
Comment 7 Lucas Gass 2023-04-24 23:01:25 UTC
Created attachment 150178 [details] [review]
Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place
Comment 8 Lucas Gass 2023-04-24 23:02:01 UTC
(In reply to Katrin Fischer from comment #6)
> Looking at this and as I won't finish right now, leaving a first note:
> 
> ItemsDeniedRenewal: I feel the placement of the links right after the
> examples you can copy and paste is not ideal. Maybe we could put them into
> an explanatory sentence below?

I attached a follow-up to move those links. Let me know if you think that is better!
Comment 9 Katrin Fischer 2023-05-09 21:40:05 UTC
Created attachment 150909 [details] [review]
Bug 33390: Add links to various system preference descriptions

To test:
1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense:

DefaultLongOverdueChargeValue
DefaultLongOverdueLostValue and DefaultLongOverdueDays
DefaultLongOverdueSkipLostStatuses
UpdateItemWhenLostFromHoldList

NewItemsDefaultLocation
UpdateItemLocationOnCheckin

SkipHoldTrapOnNotForLoanValue
UpdateNotForLoanStatusOnCheckin
Reference_NFL_Statuses

ItemsDeniedRenewal

Signed-off-by: Catrina <catrina@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2023-05-09 21:40:07 UTC
Created attachment 150910 [details] [review]
Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2023-05-09 21:40:10 UTC
Created attachment 150911 [details] [review]
Bug 33390: (QA follow-up) Rephrase some preferences

* to include 'authorised value' in text
* to keep sentences on one line (translation)
* to use sentences instead of just links in some places

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2023-05-09 21:41:02 UTC
I tried to provide some more context in a few spots. Lucas, if you hate it, please feel free to obsolete :)
Comment 13 Lucas Gass 2023-05-11 16:48:21 UTC
(In reply to Katrin Fischer from comment #12)
> I tried to provide some more context in a few spots. Lucas, if you hate it,
> please feel free to obsolete :)

It looks great to me!! Thanks for the follow-ups!
Comment 14 Lucas Gass 2023-11-01 17:15:22 UTC
Created attachment 158191 [details] [review]
Bug 33390: Add links to various system preference descriptions

To test:
1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense:

DefaultLongOverdueChargeValue
DefaultLongOverdueLostValue and DefaultLongOverdueDays
DefaultLongOverdueSkipLostStatuses
UpdateItemWhenLostFromHoldList

NewItemsDefaultLocation
UpdateItemLocationOnCheckin

SkipHoldTrapOnNotForLoanValue
UpdateNotForLoanStatusOnCheckin
Reference_NFL_Statuses

ItemsDeniedRenewal

Signed-off-by: Catrina <catrina@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 15 Lucas Gass 2023-11-01 17:15:24 UTC
Created attachment 158192 [details] [review]
Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Lucas Gass 2023-11-01 17:15:27 UTC
Created attachment 158193 [details] [review]
Bug 33390: (QA follow-up) Rephrase some preferences

* to include 'authorised value' in text
* to keep sentences on one line (translation)
* to use sentences instead of just links in some places

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 17 Lucas Gass 2023-11-01 17:15:59 UTC
Rebased for current master and reset to 'Signed-off'
Comment 18 Katrin Fischer 2023-11-01 18:09:11 UTC
Created attachment 158200 [details] [review]
Bug 33390: Add links to various system preference descriptions

To test:
1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense:

DefaultLongOverdueChargeValue
DefaultLongOverdueLostValue and DefaultLongOverdueDays
DefaultLongOverdueSkipLostStatuses
UpdateItemWhenLostFromHoldList

NewItemsDefaultLocation
UpdateItemLocationOnCheckin

SkipHoldTrapOnNotForLoanValue
UpdateNotForLoanStatusOnCheckin
Reference_NFL_Statuses

ItemsDeniedRenewal

Signed-off-by: Catrina <catrina@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 19 Katrin Fischer 2023-11-01 18:09:14 UTC
Created attachment 158201 [details] [review]
Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 20 Katrin Fischer 2023-11-01 18:09:17 UTC
Created attachment 158202 [details] [review]
Bug 33390: (QA follow-up) Rephrase some preferences

* to include 'authorised value' in text
* to keep sentences on one line (translation)
* to use sentences instead of just links in some places

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 21 Tomás Cohen Arazi 2023-11-08 14:42:36 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 22 Fridolin Somers 2023-11-10 21:26:41 UTC
Not backported to avoid translation work.