Bug 33391 - Currently active menu item on navmenulist should not change style on hover
Summary: Currently active menu item on navmenulist should not change style on hover
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Pedro Amorim
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952 33381
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-01 14:48 UTC by Pedro Amorim
Modified: 2023-12-28 20:43 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:


Attachments
Bug 33391: Prevent applying hover style on navmenulist currently active item (1006 bytes, patch)
2023-04-01 14:51 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33391: Prevent applying hover style on navmenulist currently active item (1.04 KB, patch)
2023-04-03 14:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 33391: Prevent applying hover style on navmenulist currently active item (1.11 KB, patch)
2023-04-06 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-04-01 14:48:14 UTC
If you go to system preferences with "Accounting" menu item active:
/cgi-bin/koha/admin/preferences.pl?tab=accounting
Hover on it, you'll see no difference (that's the intended behaviour)

Now go to cataloging tools - inventory with "Inventory" menu item active:
/cgi-bin/koha/tools/inventory.pl
Hover on it, you'll see the :hover is style is overriding the .current style, resulting in jumpy behaviour with bold->normal font-size.
This is happening in other places (ERM side menu, others).
Comment 1 Pedro Amorim 2023-04-01 14:51:39 UTC
Created attachment 149062 [details] [review]
Bug 33391: Prevent applying hover style on navmenulist currently active item

* Apply patch
* Run yarn css:build
* Do the 2nd example above again and verify
Comment 2 Lucas Gass (lukeg) 2023-04-03 14:38:00 UTC
Created attachment 149097 [details] [review]
Bug 33391: Prevent applying hover style on navmenulist currently active item

* Apply patch
* Run yarn css:build
* Do the 2nd example above again and verify

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2023-04-04 07:23:04 UTC
I am wondering if we should not fix bug 33381 before this one. For instance the problem still appear on /erm/agreements/add
Comment 4 Jonathan Druart 2023-04-06 07:22:38 UTC
Created attachment 149226 [details] [review]
Bug 33391: Prevent applying hover style on navmenulist currently active item

* Apply patch
* Run yarn css:build
* Do the 2nd example above again and verify

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-04-06 12:52:42 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:38:40 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 7 Lucas Gass (lukeg) 2023-05-05 21:34:04 UTC
Not needed in 22.05.x, no backport.