Bug 33398 - Show primary_contact_method when holds are triggered
Summary: Show primary_contact_method when holds are triggered
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-03 21:57 UTC by Lucas Gass
Modified: 2023-07-17 07:19 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33398: Add primary_contact_method to display when triggering a waiting hold (2.22 KB, patch)
2023-04-04 15:47 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33398: Add primary_contact_method to display when triggering a waiting hold (2.29 KB, patch)
2023-04-05 12:54 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33398: Add primary_contact_method to display when triggering a waiting hold (2.35 KB, patch)
2023-04-28 17:08 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-04-03 21:57:22 UTC
If a waiting hold is triggered a popup appears that includes "Patron notification:". This is based on the patron messaging preferences for 'Hold filled'.

We should allow libraries to choose between having this based on messaging preferences or primary_contact_method.
Comment 1 Katrin Fischer 2023-04-04 08:27:35 UTC
Hi Lucas,

I am not sure if I understand this one.

I think the idea of the display is to show if an email notification was sent out or not. The primary contact method from the patron record currently does have no effect and is only for display.

Maybe it could be shown additionally instead of instead?
Comment 2 Lucas Gass 2023-04-04 14:06:13 UTC
(In reply to Katrin Fischer from comment #1)
> Hi Lucas,
> 
> I am not sure if I understand this one.
> 
> I think the idea of the display is to show if an email notification was sent
> out or not. The primary contact method from the patron record currently does
> have no effect and is only for display.
> 
> Maybe it could be shown additionally instead of instead?

Showing it additionally would be fine with me. Changing the title of this bug to reflect that.
Comment 3 Lucas Gass 2023-04-04 15:47:20 UTC
Created attachment 149136 [details] [review]
Bug 33398: Add primary_contact_method to display when triggering a waiting hold

To test:
1. Apply patch, yarn build
2. Trigger a waiting hold for a patron that has a value for primary_contact_method
3. Notice the modal now includes a line indicating the primary_contact_method.
4. Trigger a hold for a patron without a primary_contact_method. Nothing should display.
Comment 4 ByWater Sandboxes 2023-04-05 12:54:16 UTC
Created attachment 149202 [details] [review]
Bug 33398: Add primary_contact_method to display when triggering a waiting hold

To test:
1. Apply patch, yarn build
2. Trigger a waiting hold for a patron that has a value for primary_contact_method
3. Notice the modal now includes a line indicating the primary_contact_method.
4. Trigger a hold for a patron without a primary_contact_method. Nothing should display.

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 5 Kyle M Hall 2023-04-28 17:08:11 UTC
Created attachment 150399 [details] [review]
Bug 33398: Add primary_contact_method to display when triggering a waiting hold

To test:
1. Apply patch, yarn build
2. Trigger a waiting hold for a patron that has a value for primary_contact_method
3. Notice the modal now includes a line indicating the primary_contact_method.
4. Trigger a hold for a patron without a primary_contact_method. Nothing should display.

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-06-12 18:46:20 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-07-17 07:19:26 UTC
Enhancement, no backport for 23.05.x