Bug 33402 - ERM Cypress tests needs to be moved to their own directory
Summary: ERM Cypress tests needs to be moved to their own directory
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 32030 33370
Blocks: 33408
  Show dependency treegraph
 
Reported: 2023-04-04 11:26 UTC by Jonathan Druart
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.06


Attachments
Bug 33402: Move ERM Cypress tests to their own directory (2.26 KB, patch)
2023-04-04 11:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33402: Move ERM Cypress tests to their own directory (2.32 KB, patch)
2023-04-05 10:50 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33402: Move ERM Cypress tests to their own directory (2.37 KB, patch)
2023-04-09 04:47 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 33402: Move ERM Cypress tests to their own directory (2.44 KB, patch)
2023-04-12 12:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33402: (follow-up) Move Searchbar_spec.ts (685 bytes, patch)
2023-04-12 13:54 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-04-04 11:26:43 UTC
We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM
Comment 1 Jonathan Druart 2023-04-04 11:31:05 UTC
Created attachment 149125 [details] [review]
Bug 33402: Move ERM Cypress tests to their own directory

We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts )
to their own subdirectory, eg t/cypress/integration/ERM

Test plan:
Confirm that the cypress tests are still passing after this change:
  perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only
Comment 2 Pedro Amorim 2023-04-05 10:50:22 UTC
Created attachment 149192 [details] [review]
Bug 33402: Move ERM Cypress tests to their own directory

We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts )
to their own subdirectory, eg t/cypress/integration/ERM

Test plan:
Confirm that the cypress tests are still passing after this change:
  perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Victor Grousset/tuxayo 2023-04-09 04:47:29 UTC
Created attachment 149336 [details] [review]
Bug 33402: Move ERM Cypress tests to their own directory

We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts )
to their own subdirectory, eg t/cypress/integration/ERM

Test plan:
Confirm that the cypress tests are still passing after this change:
  perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-04-09 04:47:45 UTC
Works[1], makes sense, QA script happy, code looks good, passing QA :)

[1] with and without the patch, I got the same consistent failures of Licenses_spec.ts and random failures in other files. btw, is the CI running them? I couldn't find cypress output in the last builds.
Comment 5 Jonathan Druart 2023-04-11 07:23:47 UTC
(In reply to Victor Grousset/tuxayo from comment #4)
> btw, is the CI running them

They are run at the end if no other failure happened.
Comment 6 Tomás Cohen Arazi 2023-04-12 12:28:19 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-04-12 12:42:49 UTC
Created attachment 149534 [details] [review]
Bug 33402: Move ERM Cypress tests to their own directory

We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts )
to their own subdirectory, eg t/cypress/integration/ERM

Test plan:
Confirm that the cypress tests are still passing after this change:
  perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2023-04-12 12:58:12 UTC
Doh.. my bad.. I missed that Victor had already QA'd.. 

All good.. it's been pushed too now.
Comment 9 Jonathan Druart 2023-04-12 13:23:16 UTC
It's missing a test file that has been created in the meanwhile.

git mv t/cypress/integration/Searchbar_spec.ts t/cypress/integration/ERM/Searchbar_spec.ts
Comment 10 Tomás Cohen Arazi 2023-04-12 13:54:39 UTC
Created attachment 149553 [details] [review]
Bug 33402: (follow-up) Move Searchbar_spec.ts

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 11 Victor Grousset/tuxayo 2023-04-12 20:08:02 UTC
(In reply to Jonathan Druart from comment #5)
> (In reply to Victor Grousset/tuxayo from comment #4)
> > btw, is the CI running them
> 
> They are run at the end if no other failure happened.

ok!
Comment 12 Matt Blenkinsop 2023-04-17 09:02:24 UTC
Not backporting as additional_work_needed flag is active and this is dependent on 33408 which has not been backported

Not changing status to RESOLVED FIXED - is the additional_work_needed flag still required now that Searchbar_spec.ts has been migrated?
Comment 13 Martin Renvoize 2023-04-27 12:25:01 UTC
The dependency is the other way around.. 33408 depends upon this.

I think the additional_work_needed is a red herring too at this point.. I'm sure Tomas has pushed the follow-up.
Comment 14 Jacob O'Mara 2023-05-09 20:52:36 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 15 Lucas Gass 2023-05-15 14:37:45 UTC
Not needed for 22.05.x, no backport