Bug 33410 - Use template wrapper for breadcrumbs: Patron card creator
Summary: Use template wrapper for breadcrumbs: Patron card creator
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-04 16:38 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33410: Use template wrapper for breadcrumbs: Patron card creator (15.95 KB, patch)
2023-04-04 16:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33410: Use template wrapper for breadcrumbs: Patron card creator (16.03 KB, patch)
2023-04-05 10:19 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33410: Use template wrapper for breadcrumbs: Patron card creator (16.07 KB, patch)
2023-04-08 20:20 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-04 16:38:06 UTC
To continue the process started by Bug 32507, this patch will update patron card creator templates so that they use the new template wrapper for breadcrumbs.

- patroncards/edit-batch.tt
- patroncards/edit-layout.tt
- patroncards/edit-profile.tt
- patroncards/edit-template.tt
- patroncards/home.tt
- patroncards/image-manage.tt
- patroncards/manage.tt
Comment 1 Owen Leonard 2023-04-04 16:59:23 UTC
Created attachment 149138 [details] [review]
Bug 33410: Use template wrapper for breadcrumbs: Patron card creator

This patch updates several patron card creator templates so that they
use the new WRAPPER for displaying breadcrumbs.

Unrelated minor change: I added <span> around a few other strings in
edit-profile.tt and edit-template.tt in order to improve
translatability.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron card creator
    - New ->
      - Card batch
      - Image
      - Layout
      - Card template
      - Printer profile
    - Manage ->
      - Card batches
      - Images
      - Layouts
      - Card templates
      - Printer profiles
Comment 2 Matt Blenkinsop 2023-04-05 10:19:38 UTC
Created attachment 149191 [details] [review]
Bug 33410: Use template wrapper for breadcrumbs: Patron card creator

This patch updates several patron card creator templates so that they
use the new WRAPPER for displaying breadcrumbs.

Unrelated minor change: I added <span> around a few other strings in
edit-profile.tt and edit-template.tt in order to improve
translatability.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron card creator
    - New ->
      - Card batch
      - Image
      - Layout
      - Card template
      - Printer profile
    - Manage ->
      - Card batches
      - Images
      - Layouts
      - Card templates
      - Printer profiles

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-04-08 20:20:19 UTC
Created attachment 149302 [details] [review]
Bug 33410: Use template wrapper for breadcrumbs: Patron card creator

This patch updates several patron card creator templates so that they
use the new WRAPPER for displaying breadcrumbs.

Unrelated minor change: I added <span> around a few other strings in
edit-profile.tt and edit-template.tt in order to improve
translatability.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron card creator
    - New ->
      - Card batch
      - Image
      - Layout
      - Card template
      - Printer profile
    - Manage ->
      - Card batches
      - Images
      - Layouts
      - Card templates
      - Printer profiles

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-12 12:28:27 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:38:46 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.