$overlay_framework = undef if $overlay_framework = '_USE_ORIG'; should clearly be: $overlay_framework = undef if $overlay_framework eq '_USE_ORIG';
Created attachment 149201 [details] [review] Bug 33412: Fix comparison
Created attachment 150191 [details] [review] Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off
Created attachment 150622 [details] [review] Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
As the feature is already in stable releases it might be nice to rephrase the bug description a little to be more descriptive of how the problem manifests.
*** Bug 33342 has been marked as a duplicate of this bug. ***
(In reply to Katrin Fischer from comment #4) > As the feature is already in stable releases it might be nice to rephrase > the bug description a little to be more descriptive of how the problem > manifests. Strongly agree. What about adding stage marc import and manage-marc-import.pl keywords in the title?
Test plan was missing a step where you import with Keep original framework and verify that the job succeeds. Since the option value is _USE_ORIG_ with a trailing underscore, it doesn't get undeffed by checking for eq to _USE_ORIG without a trailing underscore, and the job fails.
Some discussion on this issue on the mailing list over the last couple of days: - Development list: https://lists.koha-community.org/pipermail/koha-devel/2023-May/048136.html - Main list: https://lists.katipo.co.nz/pipermail/koha/2023-May/059402.html
Created attachment 150804 [details] [review] Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off
Created attachment 150809 [details] [review] Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: David Nind <david@davidnind.com>
I've now repeated the steps several times, but this doesn't seem to work right for me: 1) Exported Perl best practices (biblionumber 5) 2) Staged for import, match on biblionumber, replace, don't process items 3) The record matched on biblionumber 4) When replacing records use this framework: Kit 5) Imported the record 6) Framework remains Books, Booklets, ... Patch was applied, restarted all multiple times.
Created attachment 150817 [details] Screenshots - settings and results after patch applied I tested again, using the record you used, and it still worked for me. So I'm not sure why it isn't working for you 8-(. I also tested with settings changed about not checking for embedded data and not importing items (even though there isn't in this case), but it still worked. Also, I normally go flushed_memcached and restart_all after applying a patch, as well as using a fresh browser (with a cleared cache). This time I just did a restart_all and then used the same browser windows. It still worked OK. In addition, I re-staged the file for import, rather than using the previously staged batch. I've attached some screenshots of the settings I used and the results, if this helps.
Hi David, thx for taking the time! I'll reset to Signed off, I won't have time right now to dig deeper on this one and another set of eyes might help.
Created attachment 150822 [details] [review] Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport.