Bug 33414 - Dates displayed in ISO format in orders by fund
Summary: Dates displayed in ISO format in orders by fund
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30718
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-05 02:55 UTC by Fridolin Somers
Modified: 2023-12-28 20:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33414: Fix dates display in orders by fund (1.82 KB, patch)
2023-04-05 03:01 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 33414: Fix dates display in orders by fund (1.89 KB, patch)
2023-04-05 07:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33414: Add the data-order class (1.42 KB, patch)
2023-04-05 07:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33414: Fix dates display in orders by fund (1.94 KB, patch)
2023-04-09 12:14 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33414: Add the data-order class (1.47 KB, patch)
2023-04-09 12:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-04-05 02:55:06 UTC
Since Bug 30718, dates are displayed in ISO format in orders by fund
Comment 1 Fridolin Somers 2023-04-05 03:01:10 UTC
Created attachment 149154 [details] [review]
Bug 33414: Fix dates display in orders by fund

Since Bug 30718, dates are displayed in ISO format in orders by fund.
It removed dates formating in perl, this must be added in template.

Test plan :
1) Create some fresh orders on a fund F1
2) Go to Acquisitions > Orders by fund
3) Select fund F1 and 'To screen into the browser'
4) Submit
5) Check you see a formatted date in 'Entry date' column
6) Recieve some order from fund F1
Repeat 2 to 4
7) Check you see formatted date in 'Date received' column
Comment 2 Jonathan Druart 2023-04-05 07:12:05 UTC
Created attachment 149156 [details] [review]
Bug 33414: Fix dates display in orders by fund

Since Bug 30718, dates are displayed in ISO format in orders by fund.
It removed dates formating in perl, this must be added in template.

Test plan :
1) Create some fresh orders on a fund F1
2) Go to Acquisitions > Orders by fund
3) Select fund F1 and 'To screen into the browser'
4) Submit
5) Check you see a formatted date in 'Entry date' column
6) Recieve some order from fund F1
Repeat 2 to 4
7) Check you see formatted date in 'Date received' column

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2023-04-05 07:12:08 UTC
Created attachment 149157 [details] [review]
Bug 33414: Add the data-order class

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Katrin Fischer 2023-04-09 12:14:59 UTC
Created attachment 149361 [details] [review]
Bug 33414: Fix dates display in orders by fund

Since Bug 30718, dates are displayed in ISO format in orders by fund.
It removed dates formating in perl, this must be added in template.

Test plan :
1) Create some fresh orders on a fund F1
2) Go to Acquisitions > Orders by fund
3) Select fund F1 and 'To screen into the browser'
4) Submit
5) Check you see a formatted date in 'Entry date' column
6) Recieve some order from fund F1
Repeat 2 to 4
7) Check you see formatted date in 'Date received' column

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-04-09 12:15:02 UTC
Created attachment 149362 [details] [review]
Bug 33414: Add the data-order class

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-04-12 14:44:49 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-04-17 09:11:28 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-05-05 21:59:42 UTC
Missing dependencies for 22.05.x, no backport.