To reproduce: 1. In suggestion.pl in the staff client, select "Viewing suggestions for library: Any" 2. Using the "Suggestion information" filters on the left of the page, select a particular status to filter by and click "Go" Result: When the page reloads, suggestions of all statuses are shown, regardless of the selected filter. In 22.5.09, the drop-down to filter by Status also resets to "All" (although the URL parameter appears correct). In 22.11 and master, the drop-down to filter by Status retains the selected value but the results are not filtered. If you set the drop-down for "Viewing suggestions for library" to a particular library and try again to filter by status, it filters correctly.
Created attachment 150959 [details] [review] Bug 33421: Fix filtering suggestions by status If the display is by status and a specific status is selected in the filter, the filter won't have any effects. Test plan: Create several suggestions, with different status, for different libraries. Use the "display by status" view and filter on a given status => Result must be relevant
Created attachment 151076 [details] [review] Bug 33421: Fix filtering suggestions by status If the display is by status and a specific status is selected in the filter, the filter won't have any effects. Test plan: Create several suggestions, with different status, for different libraries. Use the "display by status" view and filter on a given status => Result must be relevant Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 151338 [details] [review] Bug 33421: Fix filtering suggestions by status If the display is by status and a specific status is selected in the filter, the filter won't have any effects. Test plan: Create several suggestions, with different status, for different libraries. Use the "display by status" view and filter on a given status => Result must be relevant Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x