To continue the process started by Bug 32507, this patch will update plugins templates so that they use the new template wrapper for breadcrumbs. - plugins-disabled.tt - plugins-home.tt - plugins-upload.tt
Created attachment 149230 [details] [review] Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: <enable_plugins>0</enable_plugins> - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): <enable_plugins>1</enable_plugins> - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page.
I notice that on the plugins-home page (page title Plugins > Tools > Koha), the breadcrumb is: home > Tools > Plugins But on the plugins-upload page (page title Upload plugin > Plugins > Tools > Koha), the breadcrumb is: home > Plugins > Upload plugins Is this what you intended? I wasn't able to test the 'plugins-disabled' page.
There are some existing inconsistencies in the plugins breadcrumbs which stem from the conflict between Koha's division of "tool plugin" from "other plugin." My patch doesn't attempt to resolve this, it just replaces the markup around what is there.
Created attachment 149288 [details] [review] Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: <enable_plugins>0</enable_plugins> - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): <enable_plugins>1</enable_plugins> - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 149301 [details] [review] Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: <enable_plugins>0</enable_plugins> - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): <enable_plugins>1</enable_plugins> - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.