Bug 33429 - Use template wrapper for breadcrumbs: Plugins
Summary: Use template wrapper for breadcrumbs: Plugins
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-06 10:40 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33429: Use template wrapper for breadcrumbs: Plugins (5.29 KB, patch)
2023-04-06 11:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33429: Use template wrapper for breadcrumbs: Plugins (5.33 KB, patch)
2023-04-07 18:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 33429: Use template wrapper for breadcrumbs: Plugins (5.39 KB, patch)
2023-04-08 20:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-06 10:40:24 UTC
To continue the process started by Bug 32507, this patch will update plugins templates so that they use the new template wrapper for breadcrumbs.

- plugins-disabled.tt
- plugins-home.tt
- plugins-upload.tt
Comment 1 Owen Leonard 2023-04-06 11:15:28 UTC
Created attachment 149230 [details] [review]
Bug 33429: Use template wrapper for breadcrumbs: Plugins

This patch updates plugin management templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- In koha-conf.xml, look for "enable_plugins"
  - If this is set to 0, plugins are disabled:
    <enable_plugins>0</enable_plugins>
    - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which
      should say "Plugins disabled." Check the breadcrumbs on this page.
  - Enable plugins by changing the settimg in koha-conf.xml to 1 (a
    restart of services is required): <enable_plugins>1</enable_plugins>
  - Go to Administration -> Manage plugins
    - Test this page and the "Upload plugin" page.
Comment 2 Andrew Auld 2023-04-06 15:14:02 UTC
I notice that on the plugins-home page (page title Plugins > Tools > Koha), the breadcrumb is:
home > Tools > Plugins
But on the plugins-upload page (page title Upload plugin > Plugins > Tools > Koha), the breadcrumb is:
home > Plugins > Upload plugins

Is this what you intended?

I wasn't able to test the 'plugins-disabled' page.
Comment 3 Owen Leonard 2023-04-06 18:28:28 UTC
There are some existing inconsistencies in the plugins breadcrumbs which stem from the conflict between Koha's division of "tool plugin" from "other plugin."

My patch doesn't attempt to resolve this, it just replaces the markup around what is there.
Comment 4 David Nind 2023-04-07 18:48:39 UTC
Created attachment 149288 [details] [review]
Bug 33429: Use template wrapper for breadcrumbs: Plugins

This patch updates plugin management templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- In koha-conf.xml, look for "enable_plugins"
  - If this is set to 0, plugins are disabled:
    <enable_plugins>0</enable_plugins>
    - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which
      should say "Plugins disabled." Check the breadcrumbs on this page.
  - Enable plugins by changing the settimg in koha-conf.xml to 1 (a
    restart of services is required): <enable_plugins>1</enable_plugins>
  - Go to Administration -> Manage plugins
    - Test this page and the "Upload plugin" page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2023-04-08 20:15:50 UTC
Created attachment 149301 [details] [review]
Bug 33429: Use template wrapper for breadcrumbs: Plugins

This patch updates plugin management templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- In koha-conf.xml, look for "enable_plugins"
  - If this is set to 0, plugins are disabled:
    <enable_plugins>0</enable_plugins>
    - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which
      should say "Plugins disabled." Check the breadcrumbs on this page.
  - Enable plugins by changing the settimg in koha-conf.xml to 1 (a
    restart of services is required): <enable_plugins>1</enable_plugins>
  - Go to Administration -> Manage plugins
    - Test this page and the "Upload plugin" page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-04-12 12:28:30 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-04-16 20:38:53 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.