Bug 33434 - Use template wrapper for breadcrumbs: Point of sale
Summary: Use template wrapper for breadcrumbs: Point of sale
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-06 16:03 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33434: Use template wrapper for breadcrumbs: Point of sale (4.72 KB, patch)
2023-04-06 18:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33434: Use template wrapper for breadcrumbs: Point of sale (4.76 KB, patch)
2023-04-07 19:59 UTC, David Nind
Details | Diff | Splinter Review
Bug 33434: Use template wrapper for breadcrumbs: Point of sale (4.82 KB, patch)
2023-04-08 20:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-06 16:03:10 UTC
To continue the process started by Bug 32507, this patch will update point of sale templates so that they use the new template wrapper for breadcrumbs.

- pos/pay.tt
- pos/register.tt
- pos/registers.tt
Comment 1 Owen Leonard 2023-04-06 18:36:37 UTC
Created attachment 149246 [details] [review]
Bug 33434: Use template wrapper for breadcrumbs: Point of sale

This patch updates point of sale templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- If necessary, enable the EnablePointOfSale and UseCashRegisters system
  preferences.
  - If none are configured, define at least one register and at least
    one debit type by going to Administration -> Cash registers and
    Administration -> Debit types.
  - From the staff interface's user menu in the upper right of the
    header, choose "Set library and cash register."
  - Select a cash register.
  - Go to the Point of Sale page, and check the breadcrumbs on that
    page.
    - Check the "Transaction history for [register name]" and "Cash
      summary for [library] pages linked in the left-hand sidebar.
Comment 2 David Nind 2023-04-07 19:59:41 UTC
Created attachment 149291 [details] [review]
Bug 33434: Use template wrapper for breadcrumbs: Point of sale

This patch updates point of sale templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- If necessary, enable the EnablePointOfSale and UseCashRegisters system
  preferences.
  - If none are configured, define at least one register and at least
    one debit type by going to Administration -> Cash registers and
    Administration -> Debit types.
  - From the staff interface's user menu in the upper right of the
    header, choose "Set library and cash register."
  - Select a cash register.
  - Go to the Point of Sale page, and check the breadcrumbs on that
    page.
    - Check the "Transaction history for [register name]" and "Cash
      summary for [library] pages linked in the left-hand sidebar.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-04-08 20:02:31 UTC
Created attachment 149300 [details] [review]
Bug 33434: Use template wrapper for breadcrumbs: Point of sale

This patch updates point of sale templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- If necessary, enable the EnablePointOfSale and UseCashRegisters system
  preferences.
  - If none are configured, define at least one register and at least
    one debit type by going to Administration -> Cash registers and
    Administration -> Debit types.
  - From the staff interface's user menu in the upper right of the
    header, choose "Set library and cash register."
  - Select a cash register.
  - Go to the Point of Sale page, and check the breadcrumbs on that
    page.
    - Check the "Transaction history for [register name]" and "Cash
      summary for [library] pages linked in the left-hand sidebar.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-12 12:28:34 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:38:56 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.