To continue the process started by Bug 32507, this patch will update several reports templates so that they use the new template wrapper for breadcrumbs. - reports/acquisitions_stats.tt - reports/bor_issues_top.tt - reports/borrowers_out.tt - reports/borrowers_stats.tt - reports/cash_register_stats.tt
Created attachment 149272 [details] [review] Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results
Created attachment 149294 [details] [review] Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. I disabled SQL strict mode[1] to run these reports: - Patrons with the most checkouts - Patrons who haven't checked out [1] To disable SQL struct mode: 1. Edit /etc/koha/sites/kohadev/koha-conf.xml 2. Change <strict_sql_modes>0</strict_sql_modes> from 1 to 0 3. Restart everything: restart_all
Created attachment 149299 [details] [review] Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.