Bug 33436 - Use template wrapper for breadcrumbs: Reports part 1
Summary: Use template wrapper for breadcrumbs: Reports part 1
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-06 18:40 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 (8.12 KB, patch)
2023-04-07 12:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 (8.17 KB, patch)
2023-04-07 21:00 UTC, David Nind
Details | Diff | Splinter Review
Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 (8.23 KB, patch)
2023-04-08 19:50 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-06 18:40:38 UTC
To continue the process started by Bug 32507, this patch will update several reports templates so that they use the new template wrapper for breadcrumbs.

 - reports/acquisitions_stats.tt
 - reports/bor_issues_top.tt
 - reports/borrowers_out.tt
 - reports/borrowers_stats.tt
 - reports/cash_register_stats.tt
Comment 1 Owen Leonard 2023-04-07 12:36:36 UTC
Created attachment 149272 [details] [review]
Bug 33436: Use template wrapper for breadcrumbs: Reports part 1

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Acquisitions statistics
    - Results
  - Patrons with the most checkouts
    - Results
  - Patrons who haven't checked out
    - Results
  - Patron statistics wizard
    - Results
Comment 2 David Nind 2023-04-07 21:00:27 UTC
Created attachment 149294 [details] [review]
Bug 33436: Use template wrapper for breadcrumbs: Reports part 1

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Acquisitions statistics
    - Results
  - Patrons with the most checkouts
    - Results
  - Patrons who haven't checked out
    - Results
  - Patron statistics wizard
    - Results

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-04-07 21:06:10 UTC
Testing notes (using KTD):

1. I disabled SQL strict mode[1] to run these reports:
   - Patrons with the most checkouts
   - Patrons who haven't checked out

[1] To disable SQL struct mode:
    1. Edit /etc/koha/sites/kohadev/koha-conf.xml
    2. Change <strict_sql_modes>0</strict_sql_modes> from 1 to 0
    3. Restart everything: restart_all
Comment 4 Katrin Fischer 2023-04-08 19:50:56 UTC
Created attachment 149299 [details] [review]
Bug 33436: Use template wrapper for breadcrumbs: Reports part 1

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Acquisitions statistics
    - Results
  - Patrons with the most checkouts
    - Results
  - Patrons who haven't checked out
    - Results
  - Patron statistics wizard
    - Results

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-04-12 12:28:38 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:38:59 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.