Bug 33437 - Use template wrapper for breadcrumbs: Reports part 2
Summary: Use template wrapper for breadcrumbs: Reports part 2
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-06 18:44 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 (15.98 KB, patch)
2023-04-17 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Edit report breadcrumb error (8.60 KB, image/png)
2023-04-18 13:55 UTC, Andrew Auld
Details
Run report breadcrumb error (8.64 KB, image/png)
2023-04-18 13:55 UTC, Andrew Auld
Details
View report breadcrumb error (8.77 KB, image/png)
2023-04-18 13:56 UTC, Andrew Auld
Details
Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 (16.04 KB, patch)
2023-04-19 11:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 (16.09 KB, patch)
2023-04-24 19:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 (16.15 KB, patch)
2023-04-29 19:49 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-06 18:44:08 UTC
To continue the process started by Bug 32507, this patch will update several more reports templates so that they use the new template wrapper for breadcrumbs.

 - reports/cat_issues_top.tt
 - reports/catalogue_out.tt
 - reports/catalogue_stats.tt
 - reports/dictionary.tt
 - reports/guided_reports_start.tt
Comment 1 Owen Leonard 2023-04-17 17:36:16 UTC Comment hidden (obsolete)
Comment 2 Andrew Auld 2023-04-18 13:52:46 UTC
Hi Owen,
I have found a couple of issues with this patch.
Firstly, I can't test the 'Items with no checkouts' results page as I am getting an error on the sandbox when I hit 'Submit':
CGI::Compile::ROOT::kohadevbox_koha_reports_catalogue_out_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: 'koha_bugs.items.barcode' isn't in GROUP BY at /kohadevbox/koha/reports/catalogue_out.pl line 51
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77


Secondly, under saved reports and in the guided reports wizard area, there are a number of pages where the breadcrumb doesn't show as it should I don't think. I have attached a number of screenshots to show what I mean. Steps 1 through 6 of the wizard are all fine. I think it is the 'edit report' screen, the 'run report' screen and the 'view report' screen that are not quite right.

All other parts of the test plan work fine.

I hope this is helpful.
Comment 3 Andrew Auld 2023-04-18 13:55:15 UTC
Created attachment 149809 [details]
Edit report breadcrumb error
Comment 4 Andrew Auld 2023-04-18 13:55:42 UTC
Created attachment 149810 [details]
Run report breadcrumb error
Comment 5 Andrew Auld 2023-04-18 13:56:05 UTC
Created attachment 149811 [details]
View report breadcrumb error
Comment 6 Owen Leonard 2023-04-19 11:24:46 UTC
Created attachment 149867 [details] [review]
Bug 33437: Use template wrapper for breadcrumbs: Reports part 2

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Most circulated items
    - Report results
  - Items with no checkouts
    - Report results
  - Catalog statistics wizard
    - Report results
  - View dictionary
    - New definition (steps 1-5)
  - Saved reports
    - View report
    - New report
    - Edit report
  - Guided reports
    - Build a report
      - Steps 1 through 6
Comment 7 Andrew Auld 2023-04-19 14:32:04 UTC
Hi Owen,
I have tested the guided reports screens and the breadcrumbs now look and behave as they should. Thank you.

I still can't run the 'Items with no checkouts' report to get to the results page. This may well be user error rather than anything to do with your patch. But it does mean I haven't been able to test the Report results page.
Comment 8 Owen Leonard 2023-04-19 15:49:59 UTC
(In reply to Andrew Auld from comment #7)
> I still can't run the 'Items with no checkouts' report to get to the results
> page.

Ah right, sorry I didn't comment on that issue. That seems to be a bug related to strict_sql_modes and can't be worked around unless you have access to koha-conf.xml
Comment 9 David Nind 2023-04-24 19:05:01 UTC
Created attachment 150171 [details] [review]
Bug 33437: Use template wrapper for breadcrumbs: Reports part 2

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Most circulated items
    - Report results
  - Items with no checkouts
    - Report results
  - Catalog statistics wizard
    - Report results
  - View dictionary
    - New definition (steps 1-5)
  - Saved reports
    - View report
    - New report
    - Edit report
  - Guided reports
    - Build a report
      - Steps 1 through 6

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2023-04-24 19:09:08 UTC
Testing notes (using KTD):

1. To turn off the strict database mode:
   - Edit /etc/koha/sites/kohadev/koha-conf.xml
   - Change strict_sql_modes from 1 to 0 (is right near the end of the file): <strict_sql_modes>0</strict_sql_modes>
   - flush_memcached and restart_all
Comment 11 Nick Clemens 2023-04-29 19:49:00 UTC
Created attachment 150423 [details] [review]
Bug 33437: Use template wrapper for breadcrumbs: Reports part 2

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Most circulated items
    - Report results
  - Items with no checkouts
    - Report results
  - Catalog statistics wizard
    - Report results
  - View dictionary
    - New definition (steps 1-5)
  - Saved reports
    - View report
    - New report
    - Edit report
  - Guided reports
    - Build a report
      - Steps 1 through 6

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 12 Tomás Cohen Arazi 2023-05-05 12:17:26 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 13 Martin Renvoize 2023-05-11 11:23:52 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release