Bug 33106 adds a link from the vendor to the licenses. It would make sense to also have it the other way around. The easiest would be to link the vendor name in the table of licenses.
Created attachment 149417 [details] [review] Bug 33466: Link to the vendor from the ERM module There are 3 tables in the ERM module where we display the vendor name but without a link to the acquisition module. This patch adds the links. Test plan: Create an agreement, a license and a local package. Pick a vendor and notice that now there is a link on the list view.
Patch failed to apply: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue). error: could not build fake ancestor Patch failed at 0001 Bug 33466: Link to the vendor from the ERM module hint: Use 'git am --show-current-patch=diff' to see the failed patch
(In reply to Laura Escamilla from comment #2) > Patch failed to apply: Can you pull the latest master and try again please? It looks ok for me.
Created attachment 149466 [details] [review] Bug 33466: Link to the vendor from the ERM module There are 3 tables in the ERM module where we display the vendor name but without a link to the acquisition module. This patch adds the links. Test plan: Create an agreement, a license and a local package. Pick a vendor and notice that now there is a link on the list view. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Enable the ERM module (ERMModule system preference). 2. In the ERM module add an agreement, a licence, and a package - when creating this use 'My Vendor' for the vendor field for each of them. 3. Note that in the table listings for agreements, licences, and packages that 'My Vendor' in the vendor column is not linked to the vendor record. 4. Apply the patch. 5. Run: yarn build 6. Restart everything (restart_all). 7. Now note for step 3, that 'My Vendor' is now linked to the vendor record (and correctly goes to the vendor page).
Created attachment 149478 [details] [review] Bug 33466: Link to the vendor from the ERM module There are 3 tables in the ERM module where we display the vendor name but without a link to the acquisition module. This patch adds the links. Test plan: Create an agreement, a license and a local package. Pick a vendor and notice that now there is a link on the list view. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Enhancement - not backporting to 22.11.x Nice work everyone!
For 22.11.06 I've decided to incorporate the majority of ERM improvements.. a lot of work has gone into improving ERM this cycle and for long term maintenance I think it makes sense to include these changes at this stage.
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Documented by Jonathan Field.