Bug 33466 - Link vendor name in list of licenses
Summary: Link vendor name in list of licenses
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-09 13:51 UTC by Katrin Fischer
Modified: 2024-04-17 10:30 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33466: Link to the vendor from the ERM module (3.74 KB, patch)
2023-04-11 09:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33466: Link to the vendor from the ERM module (3.78 KB, patch)
2023-04-11 18:52 UTC, David Nind
Details | Diff | Splinter Review
Bug 33466: Link to the vendor from the ERM module (3.83 KB, patch)
2023-04-11 20:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-09 13:51:14 UTC
Bug 33106 adds a link from the vendor to the licenses. It would make sense to also have it the other way around. The easiest would be to link the vendor name in the table of licenses.
Comment 1 Jonathan Druart 2023-04-11 09:29:01 UTC
Created attachment 149417 [details] [review]
Bug 33466: Link to the vendor from the ERM module

There are 3 tables in the ERM module where we display the vendor name
but without a link to the acquisition module.

This patch adds the links.

Test plan:
Create an agreement, a license and a local package.
Pick a vendor and notice that now there is a link on the list view.
Comment 2 Laura Escamilla 2023-04-11 11:29:14 UTC
Patch failed to apply: 

error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue).
error: could not build fake ancestor
Patch failed at 0001 Bug 33466: Link to the vendor from the ERM module
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Comment 3 Jonathan Druart 2023-04-11 12:29:26 UTC
(In reply to Laura Escamilla from comment #2)
> Patch failed to apply: 

Can you pull the latest master and try again please?
It looks ok for me.
Comment 4 David Nind 2023-04-11 18:52:32 UTC
Created attachment 149466 [details] [review]
Bug 33466: Link to the vendor from the ERM module

There are 3 tables in the ERM module where we display the vendor name
but without a link to the acquisition module.

This patch adds the links.

Test plan:
Create an agreement, a license and a local package.
Pick a vendor and notice that now there is a link on the list view.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-04-11 18:59:09 UTC
Testing notes (using KTD):

1. Enable the ERM module (ERMModule system preference).

2. In the ERM module add an agreement, a licence, and a package - when creating this use 'My Vendor' for the vendor field for each of them.

3. Note that in the table listings for agreements, licences, and packages that 'My Vendor' in the vendor column is not linked to the vendor record.

4. Apply the patch.

5. Run: yarn build

6. Restart everything (restart_all).

7. Now note for step 3, that 'My Vendor' is now linked to the vendor record (and correctly goes to the vendor page).
Comment 6 Katrin Fischer 2023-04-11 20:53:44 UTC
Created attachment 149478 [details] [review]
Bug 33466: Link to the vendor from the ERM module

There are 3 tables in the ERM module where we display the vendor name
but without a link to the acquisition module.

This patch adds the links.

Test plan:
Create an agreement, a license and a local package.
Pick a vendor and notice that now there is a link on the list view.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-04-13 14:50:00 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-04-17 09:13:56 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 9 Martin Renvoize 2023-05-11 16:18:07 UTC
For 22.11.06 I've decided to incorporate the majority of ERM improvements.. a lot of work has gone into improving ERM this cycle and for long term maintenance I think it makes sense to include these changes at this stage.
Comment 10 Martin Renvoize 2023-05-11 16:19:22 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 11 Aude Charillon 2024-04-17 10:30:52 UTC
Documented by Jonathan Field.