Created attachment 149435 [details] [review] Bug 33482: Propagate errors from EBSCO's ws to the UI When adding or removing eholdings from EBSCO, if an error happens it is lost and not propagated to the UI. We were missing a return in the logic, and always returning 200 Test plan: Do not apply (or revert) bug 33481 Configure EBSCO for ERM and add a package to your holdings With this patch applied you will get a 500 that is propagated to the UI Without this patch nothing happens and the user is not aware that something bad happened
Created attachment 149439 [details] [review] Bug 33482: Add Unsupported Media Type exception
Created attachment 149440 [details] [review] Bug 33482: Unsupported Media Type exception in packages patch method This adds the Unsupported Media Type exception error code and error message to the UI
The error code and message are now showing when reproducing the error for packages and titles, however you'll notice the patch only contains changes to erm_eholdings_packages.yaml, this is because "adding titles to holdings" is using the same endpoint. @Joubu just to confirm, is this intended?
Created attachment 149450 [details] [review] Bug 33482: Propagate errors from EBSCO's ws to the UI When adding or removing eholdings from EBSCO, if an error happens it is lost and not propagated to the UI. We were missing a return in the logic, and always returning 200 Test plan: Do not apply (or revert) bug 33481 Configure EBSCO for ERM and add a package to your holdings With this patch applied you will get a 500 that is propagated to the UI Without this patch nothing happens and the user is not aware that something bad happened Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 149508 [details] [review] Bug 33408: We need only one this.loaded call Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 150292 [details] [review] Bug 33482: Propagate errors from EBSCO's ws to the UI When adding or removing eholdings from EBSCO, if an error happens it is lost and not propagated to the UI. We were missing a return in the logic, and always returning 200 Test plan: Do not apply (or revert) bug 33481 Configure EBSCO for ERM and add a package to your holdings With this patch applied you will get a 500 that is propagated to the UI Without this patch nothing happens and the user is not aware that something bad happened Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All working as expected, no QA failures. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release