Bug 33486 - Remove Koha::BackgroundJob::UpdateElasticIndex->process routine
Summary: Remove Koha::BackgroundJob::UpdateElasticIndex->process routine
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact:
URL:
Keywords:
Depends on: 32594
Blocks: 33316
  Show dependency treegraph
 
Reported: 2023-04-11 13:40 UTC by Nick Clemens
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33486: Remove Koha::BackgroundJob::UpdateElasticIndex->process (2.06 KB, patch)
2023-04-11 13:44 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33486: Remove Koha::BackgroundJob::UpdateElasticIndex->process (2.14 KB, patch)
2023-04-13 07:17 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-04-11 13:40:50 UTC
Bug 32594 introduced a dedicated worker for ES background jobs. It now handles all elastic indexing, and should be the only process that does so.

To avoid confusion, we should remove the 'process' method from the background module as it is not expected to be called
Comment 1 Nick Clemens 2023-04-11 13:44:14 UTC
Created attachment 149443 [details] [review]
Bug 33486: Remove Koha::BackgroundJob::UpdateElasticIndex->process
Comment 2 Jonathan Druart 2023-04-13 07:17:47 UTC
Created attachment 149584 [details] [review]
Bug 33486: Remove Koha::BackgroundJob::UpdateElasticIndex->process

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Tomás Cohen Arazi 2023-04-13 14:50:04 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 4 Matt Blenkinsop 2023-04-17 09:11:31 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 5 Martin Renvoize 2023-05-03 11:52:52 UTC
22.11.05 should NOT have had this.. we missed the dependencies as they weren't listed in the depends on.  I'm reverting for a 22.11.05-1 release.

We'll be restoring this, along with the proper tree of bugs beneath it for 22.11.06
Comment 6 Martin Renvoize 2023-05-03 12:22:48 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 7 Lucas Gass 2023-05-05 22:07:36 UTC
Missing 22.05.x dependencies, no backport.