In a consortium with many libraries, the branch transfer limits can become complex and have many rows - we have seen 750k+ At this size, searching on limits can take 1/2 a second or more - and when a record has many items this begins to add up fast Adding an index to the fromBranch column greatly reduces the cost of a lookup: CREATE INDEX fromBranch_index ON branch_transfer_limits (fromBranch);
Created attachment 149458 [details] [review] Bug 33488: Add fromBranch index to branch_transfer_limits To test: 1 - Enable UseBranchTransferLimits by item type 2 - Set some limits for book 3 - Place a hold, verify that pikcup dropdown reflects the limits before and after patch
Tested this on our test server and compared it to our production server, which has more resources and the test server worked far faster. This will be very helpful for our libraries - Bob
Created attachment 149912 [details] [review] Bug 33488: Add fromBranch index to branch_transfer_limits To test: 1 - Enable UseBranchTransferLimits by item type 2 - Set some limits for book 3 - Place a hold, verify that pikcup dropdown reflects the limits before and after patch Signed-off-by: Bob Benhoff <bbenhoff@clicweb.org>
Created attachment 149913 [details] [review] Bug 33488: Add fromBranch index to branch_transfer_limits To test: 1 - Enable UseBranchTransferLimits by item type 2 - Set some limits for book 3 - Place a hold, verify that pikcup dropdown reflects the limits before and after patch Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Created attachment 150077 [details] [review] Bug 33488: Add fromBranch index to branch_transfer_limits To test: 1 - Enable UseBranchTransferLimits by item type 2 - Set some limits for book 3 - Place a hold, verify that pikcup dropdown reflects the limits before and after patch Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 151161 [details] [review] Bug 33488: (QA follow-up) Fix index name Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release