Bug 33506 - Series has wrong index name on scan index page and search option selection is not retained
Summary: Series has wrong index name on scan index page and search option selection is...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 33505
  Show dependency treegraph
 
Reported: 2023-04-12 12:29 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.13


Attachments
Bug 33506: Fix false index for series and keep selected index on scan index page (6.43 KB, patch)
2023-04-12 20:46 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33506: Fix false index for series and keep selected index on scan index page (6.43 KB, patch)
2023-04-12 21:01 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33506: Fix false index for series and keep selected index on scan index page (6.48 KB, patch)
2023-04-13 18:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 33506: Fix false index for series and keep selected index on scan index page (6.54 KB, patch)
2023-04-27 13:33 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-12 12:29:49 UTC
On the 'scan index' page in the staff interface, there is a typo in the template:

<option value="su">Series</option>

su is the index for subjects. This should be series-title or se.
Comment 1 Katrin Fischer 2023-04-12 20:46:03 UTC
Created attachment 149576 [details] [review]
Bug 33506: Fix false index for series and keep selected index on scan index page

The pull down with search options had the wrong index
linked to the Series entry: su instead of se

To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* Verify search results link to authors using c
* Switch to series
* Verify search results use 'su' for subject
* Verify that search option pull down always jumps back to first
  entry: Any word
* Apply patch
* Verify the search results for series now use correct index se
* Verify that coming from advanced search, the correct search option is selected
* Verify that changing the search option also keeps the selection after searching

Note: with Elasticsearch and default configuration author, title and series will
give you results.
Comment 2 Katrin Fischer 2023-04-12 21:01:03 UTC
Created attachment 149577 [details] [review]
Bug 33506: Fix false index for series and keep selected index on scan index page

The pull down with search options had the wrong index
linked to the Series entry: su instead of se

To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* Verify search results link to authors using c
* Switch to series
* Verify search results use 'su' for subject
* Verify that search option pull down always jumps back to first
  entry: Any word
* Apply patch
* Verify the search results for series now use correct index se
* Verify that coming from advanced search, the correct search option is selected
* Verify that changing the search option also keeps the selection after searching

Note: with Elasticsearch and default configuration author, title and series will
give you results.
Comment 3 David Nind 2023-04-13 18:18:05 UTC
Created attachment 149620 [details] [review]
Bug 33506: Fix false index for series and keep selected index on scan index page

The pull down with search options had the wrong index
linked to the Series entry: su instead of se

To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* Verify search results link to authors using c
* Switch to series
* Verify search results use 'su' for subject
* Verify that search option pull down always jumps back to first
  entry: Any word
* Apply patch
* Verify the search results for series now use correct index se
* Verify that coming from advanced search, the correct search option is selected
* Verify that changing the search option also keeps the selection after searching

Note: with Elasticsearch and default configuration author, title and series will
give you results.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-04-13 18:27:33 UTC
Testing notes (using KTD):

1. One thing I noted (not related to this bug) is that:
   - when using Zebra, only 20 results are displayed - it looks to me like the pagination of search results is missing
   - when using Elasticsearch, there is pagination at the bottom (like the normal staff interface catalog search results)

2. Also not related to this bug, the results pages need the page section added (bug 31757).

I'm happy to add the bugs for these if they don't exist already.
Comment 5 David Nind 2023-04-14 00:53:59 UTC
(In reply to David Nind from comment #4)
> Testing notes (using KTD):
> 
> 1. One thing I noted (not related to this bug) is that:
>    - when using Zebra, only 20 results are displayed - it looks to me like
> the pagination of search results is missing
>    - when using Elasticsearch, there is pagination at the bottom (like the
> normal staff interface catalog search results)
> 
> 2. Also not related to this bug, the results pages need the page section
> added (bug 31757).
> 
> I'm happy to add the bugs for these if they don't exist already.

Please ignore this comment. I've added it to bug 33505.
Comment 6 Nick Clemens 2023-04-27 13:33:32 UTC
Created attachment 150300 [details] [review]
Bug 33506: Fix false index for series and keep selected index on scan index page

The pull down with search options had the wrong index
linked to the Series entry: su instead of se

To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* Verify search results link to authors using c
* Switch to series
* Verify search results use 'su' for subject
* Verify that search option pull down always jumps back to first
  entry: Any word
* Apply patch
* Verify the search results for series now use correct index se
* Verify that coming from advanced search, the correct search option is selected
* Verify that changing the search option also keeps the selection after searching

Note: with Elasticsearch and default configuration author, title and series will
give you results.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2023-05-05 12:17:47 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Martin Renvoize 2023-05-11 12:25:46 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 9 Lucas Gass 2023-05-15 22:27:37 UTC
Backported to 22.05.x for upcoming 22.05.13