TO recreate: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. At this point you are actually editing an item, not adding an item. This is confusing and leads librarians to never edit these items because they assume they are adding an item, not editing the existing one. Also, the 'Click to add item' is small and grey. It should look more like a button.
Created attachment 149580 [details] [review] Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item'
Created attachment 149605 [details] [review] Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Lovely...much less confusing now. :)
Created attachment 149719 [details] [review] Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Created attachment 149720 [details] [review] Bug 33512: (QA follow-up) Remove 'Click to' from buttons This is following recommendations from accessibility guidelines. It being a link or button already indicates that you need to click it. We don't need to spell it out.
Hi Lucas, I just realized that we had the "Click to..." previous to your patches, but we should not do that. I've added a small follow-up to remove them. It being a link or button already indicates that you can click it, see also accessibility guidelines like: https://www.mtu.edu/accessibility/training/web/link-text/ Hope you agree :) But: The edit/add text change doesn't work perfectly yet: To test: * Add a new subscription creating items on receive * Receive a first issue and create the item * From serial collection check both issues and edit * The unreceived issue in status "arrived also has "Edit item", but there is no item to edit yet I really like this change, can you please have another look?
(In reply to Katrin Fischer from comment #6) > Hi Lucas, > > I just realized that we had the "Click to..." previous to your patches, but > we should not do that. I've added a small follow-up to remove them. It being > a link or button already indicates that you can click it, see also > accessibility guidelines like: > https://www.mtu.edu/accessibility/training/web/link-text/ > Hope you agree :) > > But: The edit/add text change doesn't work perfectly yet: > > To test: > * Add a new subscription creating items on receive > * Receive a first issue and create the item > * From serial collection check both issues and edit > * The unreceived issue in status "arrived also has "Edit item", but there is > no item to edit yet > > I really like this change, can you please have another look? Good catch Katrin. I 100% agree with you. Should we set this back to NSO? Thanks for the follow-up!
(In reply to Lucas Gass from comment #7) > (In reply to Katrin Fischer from comment #6) > > Hi Lucas, > > > > I just realized that we had the "Click to..." previous to your patches, but > > we should not do that. I've added a small follow-up to remove them. It being > > a link or button already indicates that you can click it, see also > > accessibility guidelines like: > > https://www.mtu.edu/accessibility/training/web/link-text/ > > Hope you agree :) > > > > But: The edit/add text change doesn't work perfectly yet: > > > > To test: > > * Add a new subscription creating items on receive > > * Receive a first issue and create the item > > * From serial collection check both issues and edit > > * The unreceived issue in status "arrived also has "Edit item", but there is > > no item to edit yet > > > > I really like this change, can you please have another look? > > Good catch Katrin. I 100% agree with you. Should we set this back to NSO? > Thanks for the follow-up! I couldn't fix the second issue - so we will still need a follow up or maybe change to "Add/edit item"
Created attachment 150179 [details] [review] Bug 33512: (follow-up) Check item count before adding add/edit button
> I couldn't fix the second issue - so we will still need a follow up or maybe > change to "Add/edit item" Katrin, let me know what you think of my follow-up for the 2nd issue.
Created attachment 150906 [details] [review] Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 150907 [details] [review] Bug 33512: (QA follow-up) Remove 'Click to' from buttons This is following recommendations from accessibility guidelines. It being a link or button already indicates that you need to click it. We don't need to spell it out. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 150908 [details] [review] Bug 33512: (follow-up) Check item count before adding add/edit button Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.14
Not backporting to 21.11.x