Bug 33532 - Catalog concerns - Title of the page says Tools instead of Cataloging
Summary: Catalog concerns - Title of the page says Tools instead of Cataloging
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: David Nind
QA Contact: Testopia
URL:
Keywords:
Depends on: 31028
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-13 18:22 UTC by Caroline Cyr La Rose
Modified: 2023-12-23 08:13 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the HTML page title for the cataloging concerns management page so that it says Catalog concerns > Cataloging > Koha (as it is under cataloging, not tools).
Version(s) released in:
23.05.00


Attachments
Bug 33532: Fix HTML page title for cataloging concerns page (1.51 KB, patch)
2023-04-13 18:57 UTC, David Nind
Details | Diff | Splinter Review
Bug 33532: Fix HTML page title for cataloging concerns page (1.58 KB, patch)
2023-04-14 13:52 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33532: Fix HTML page title for cataloging concerns page (1.64 KB, patch)
2023-04-14 15:18 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-04-13 18:22:48 UTC
Very minor, but the title of the page of the Catalog concerns management page, which appears in the browser tab, says Catalog concerns > **Tools** > Koha. But the page is under Cataloging, not Tools.

To reproduce:
1. Enable the CatalogConcerns system preference
2. Go to Cataloging > Catalog concerns
   --> The title of the page in the browser tab says Tools
Comment 1 David Nind 2023-04-13 18:57:02 UTC
Created attachment 149622 [details] [review]
Bug 33532: Fix HTML page title for cataloging concerns page

The HTML title of the Catalog concerns management page (which
appears in the browser tab) says Catalog concerns > Tools >
Koha. But the page is under Cataloging, not Tools.

Test plan:
1. Enable the CatalogConcerns system preference.
2. Go to Cataloging > Catalog concerns:
   => The title of the page in the browser tab says Catalog
      concerns > Tools > Koha
3. Apply the patch.
4. Refresh the catalog concerns page.
5. The title of the page in the browser tab should now say Catalog
   concerns > Cataloging > Koha
6. Sign off 8-)

Signed-off-by: David Nind <david@davidnind.com>
Comment 2 Caroline Cyr La Rose 2023-04-14 13:52:30 UTC
Created attachment 149681 [details] [review]
Bug 33532: Fix HTML page title for cataloging concerns page

The HTML title of the Catalog concerns management page (which
appears in the browser tab) says Catalog concerns > Tools >
Koha. But the page is under Cataloging, not Tools.

Test plan:
1. Enable the CatalogConcerns system preference.
2. Go to Cataloging > Catalog concerns:
   => The title of the page in the browser tab says Catalog
      concerns > Tools > Koha
3. Apply the patch.
4. Refresh the catalog concerns page.
5. The title of the page in the browser tab should now say Catalog
   concerns > Cataloging > Koha
6. Sign off 8-)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Lucas Gass 2023-04-14 15:18:56 UTC
Created attachment 149694 [details] [review]
Bug 33532: Fix HTML page title for cataloging concerns page

The HTML title of the Catalog concerns management page (which
appears in the browser tab) says Catalog concerns > Tools >
Koha. But the page is under Cataloging, not Tools.

Test plan:
1. Enable the CatalogConcerns system preference.
2. Go to Cataloging > Catalog concerns:
   => The title of the page in the browser tab says Catalog
      concerns > Tools > Koha
3. Apply the patch.
4. Refresh the catalog concerns page.
5. The title of the page in the browser tab should now say Catalog
   concerns > Cataloging > Koha
6. Sign off 8-)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-05-05 18:43:14 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!