In memberentrygen.tt, there is a condition to show either "Patron identity" or "Organization identity" in the patron form. These three words, "Patron", "Organization", and "identity" were separated in different spans. However, in French at least, we have to invert the order of the words otherwise it doesn't make sense. So "Patron identity" becomes "Identité de l'utilisateur" ("Identity of patron"). Right now, it is translated as "Utilisateur identité" which doesn't mean anything and looks like it was translated directly from English :) This whole condition should be kept together, with %s to separate the elements so that we can move them around. <legend id="identity_lgd">[% IF ( I ) %]<span>Organization</span> [% ELSE %]<span>Patron</span> [% END %]<span>identity</span></legend>
Created attachment 149623 [details] [review] Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "Identité de l'organisme %sIdentité de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX
Created attachment 149693 [details] [review] Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "Identité de l'organisme %sIdentité de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Thx for the patch Caroline - this one has been annoying me forever!
Created attachment 149712 [details] [review] Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "Identité de l'organisme %sIdentité de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Doesn't apply cleanly to 22.05.x, no backport.