When adding or deleting patron restriction types, the dialog messages ("Type added", "Type deleted", etc.) have no styling. Normally, such messages are on a blue background. To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled To see a regular dialog message: 1. Go to Administration > Debit types 2. Click 'New debit type' 3. Enter a code and description 4. Click 'Save' --> 'Debit type saved successfully' on blue background
Created attachment 149824 [details] [review] Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly
Created attachment 149845 [details] [review] Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described, thanks for the patch.
Created attachment 149996 [details] [review] Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 149997 [details] [review] Bug 33549: Improve wording of dialog messages In terms of translations type can be a lot of things. Usually translations are easier with more context, so I've added restriction to the type :) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Not needed for 22.05.x, no backport.