Bug 33564 - Use template wrapper for breadcrumbs: Serials part 3
Summary: Use template wrapper for breadcrumbs: Serials part 3
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-19 17:43 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:


Attachments
Bug 33564: Use template wrapper for breadcrumbs: Serials part 3 (9.75 KB, patch)
2023-04-19 18:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33564: Use template wrapper for breadcrumbs: Serials part 3 (9.81 KB, patch)
2023-04-24 17:54 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 33564: Use template wrapper for breadcrumbs: Serials part 3 (9.87 KB, patch)
2023-04-29 20:02 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-19 17:43:22 UTC
To continue the process started by Bug 32507, this patch will update several more serials templates so that they use the new template wrapper for breadcrumbs.

 - serials/subscription-detail.tt
 - serials/subscription-frequencies.tt
 - serials/subscription-history.tt
 - serials/subscription-numberpatterns.tt
 - serials/viewalerts.tt
Comment 1 Owen Leonard 2023-04-19 18:27:41 UTC
Created attachment 149910 [details] [review]
Bug 33564: Use template wrapper for breadcrumbs: Serials part 3

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
 - Manage frequencies
   - New frequency
   - Edit frequency
 - Manage numbering patterns
   - New numbering pattern
   - Edit numbering pattern
 - Search subscriptions -> View subscription details
   - If necessary, edit the subscription to enable "Manual
     history"
     - Under the "Planning" tab of the detail page, click
       "Edit history"
   - If necessary, edit the subscription and select a notice under
     "Patron notification."
     - Under the "Information" tab of the subscription detail page,
       click "subscribers"
Comment 2 Biblibre Sandboxes 2023-04-24 17:54:47 UTC
Created attachment 150169 [details] [review]
Bug 33564: Use template wrapper for breadcrumbs: Serials part 3

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
 - Manage frequencies
   - New frequency
   - Edit frequency
 - Manage numbering patterns
   - New numbering pattern
   - Edit numbering pattern
 - Search subscriptions -> View subscription details
   - If necessary, edit the subscription to enable "Manual
     history"
     - Under the "Planning" tab of the detail page, click
       "Edit history"
   - If necessary, edit the subscription and select a notice under
     "Patron notification."
     - Under the "Information" tab of the subscription detail page,
       click "subscribers"

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-04-24 17:55:06 UTC
Great! Thanks Owen
Comment 4 Nick Clemens (kidclamp) 2023-04-29 20:02:27 UTC
Created attachment 150425 [details] [review]
Bug 33564: Use template wrapper for breadcrumbs: Serials part 3

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
 - Manage frequencies
   - New frequency
   - Edit frequency
 - Manage numbering patterns
   - New numbering pattern
   - Edit numbering pattern
 - Search subscriptions -> View subscription details
   - If necessary, edit the subscription to enable "Manual
     history"
     - Under the "Planning" tab of the detail page, click
       "Edit history"
   - If necessary, edit the subscription and select a notice under
     "Patron notification."
     - Under the "Information" tab of the subscription detail page,
       click "subscribers"

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-05-05 12:17:55 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-05-11 11:23:58 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release