Bug 33565 - Use template wrapper for breadcrumbs: Tags
Summary: Use template wrapper for breadcrumbs: Tags
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-19 18:44 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33565: Use template wrapper for breadcrumbs: Tags (3.18 KB, patch)
2023-04-19 18:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33565: Use template wrapper for breadcrumbs: Tags (3.24 KB, patch)
2023-04-21 14:55 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33565: Use template wrapper for breadcrumbs: Tags (3.24 KB, patch)
2023-04-21 15:33 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33565: Use template wrapper for breadcrumbs: Tags (3.29 KB, patch)
2023-04-21 16:00 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-19 18:44:51 UTC
To continue the process started by Bug 32507, this patch will update tags templates so that they use the new template wrapper for breadcrumbs.

- tags/list.tt
- tags/review.tt
Comment 1 Owen Leonard 2023-04-19 18:49:35 UTC
Created attachment 149911 [details] [review]
Bug 33565: Use template wrapper for breadcrumbs: Tags

This patch updates two tags templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Tags
    - Click a tag to see titles with that tag
Comment 2 ByWater Sandboxes 2023-04-21 14:55:38 UTC
Created attachment 150050 [details] [review]
Bug 33565: Use template wrapper for breadcrumbs: Tags

This patch updates two tags templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Tags
    - Click a tag to see titles with that tag

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 ByWater Sandboxes 2023-04-21 15:33:38 UTC
Created attachment 150055 [details] [review]
Bug 33565: Use template wrapper for breadcrumbs: Tags

This patch updates two tags templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Tags
    - Click a tag to see titles with that tag

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 4 Lucas Gass 2023-04-21 16:00:15 UTC
Created attachment 150058 [details] [review]
Bug 33565: Use template wrapper for breadcrumbs: Tags

This patch updates two tags templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Tags
    - Click a tag to see titles with that tag

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2023-04-24 13:50:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-05-10 12:55:00 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.