Bug 33566 - Use template wrapper for breadcrumbs: Tools, part 1
Summary: Use template wrapper for breadcrumbs: Tools, part 1
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-19 19:03 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 (9.85 KB, patch)
2023-04-20 12:35 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 (9.77 KB, patch)
2023-04-25 11:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 (9.84 KB, patch)
2023-04-25 12:51 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 (9.89 KB, patch)
2023-04-29 20:08 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-19 19:03:23 UTC
To continue the process started by Bug 32507, this patch will update several tools templates so that they use the new template wrapper for breadcrumbs.

- tools/access_files.tt
- tools/additional-contents.tt
- tools/automatic_item_modification_by_age.tt
- tools/batch_delete_records.tt
- tools/batch_extend_due_dates.tt
Comment 1 Owen Leonard 2023-04-20 12:35:45 UTC
Created attachment 149940 [details] [review]
Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Batch extend due dates
  - Access files (it is not necessary to have file access configured to
    test, there are no variations to the breadcrumbs)
  - News, HTML customizations, and Pages: For each category check each
    variation:
    - List of entries
    - New entry
    - Edit entry
- Cataloging ->
  - Batch record deletion
  - Item modifications by age
    - Edit rules
Comment 2 Barbara Johnson 2023-04-21 14:34:17 UTC
Everything works fine except I in the the News area. When I go to News > Edit Entry the end of the breadcrumb displays (1 News ) instead of just (News)  Any entry you click on always says (1 News ) which I don't think is the intent.  Also there is an extra space between News and the closing parenthesis.

Home > Tools > News > Modify additional content (1 News )
Comment 3 Owen Leonard 2023-04-25 11:05:19 UTC
Created attachment 150185 [details] [review]
Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Batch extend due dates
  - Access files (it is not necessary to have file access configured to
    test, there are no variations to the breadcrumbs)
  - News, HTML customizations, and Pages: For each category check each
    variation:
    - List of entries
    - New entry
    - Edit entry
- Cataloging ->
  - Batch record deletion
  - Item modifications by age
    - Edit rules
Comment 4 Biblibre Sandboxes 2023-04-25 12:51:01 UTC
Created attachment 150202 [details] [review]
Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Batch extend due dates
  - Access files (it is not necessary to have file access configured to
    test, there are no variations to the breadcrumbs)
  - News, HTML customizations, and Pages: For each category check each
    variation:
    - List of entries
    - New entry
    - Edit entry
- Cataloging ->
  - Batch record deletion
  - Item modifications by age
    - Edit rules

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 5 Nick Clemens 2023-04-29 20:08:22 UTC
Created attachment 150426 [details] [review]
Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Batch extend due dates
  - Access files (it is not necessary to have file access configured to
    test, there are no variations to the breadcrumbs)
  - News, HTML customizations, and Pages: For each category check each
    variation:
    - List of entries
    - New entry
    - Edit entry
- Cataloging ->
  - Batch record deletion
  - Item modifications by age
    - Edit rules

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-05-05 12:17:58 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-05-11 11:24:02 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release